Lifecycle Compatibility Verification #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Jones <sijones@pivotal.io> Signed-off-by: Javier Romero <jromero@pivotal.io>
This was referenced Dec 6, 2019
sclevine
approved these changes
Dec 12, 2019
jkutner
approved these changes
Dec 17, 2019
nebhale
approved these changes
Jan 8, 2020
|
I move for an FCP, ending 16 Jan, for merge. If @hone approves before that day, we'll merge early. |
hone
approved these changes
Jan 22, 2020
|
I do like how flags feel less hidden since it can be viewed in the help of a binary. There's pretty massive benefits to the env var too. Potentially, we could do both. This is a common pattern for many CLIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readable
Continuation of #29