-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform API changes for run image extension (Dockerfiles phase 3) #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0be8037
to
1f399e4
Compare
natalieparellano
commented
Feb 1, 2023
natalieparellano
commented
Feb 1, 2023
natalieparellano
commented
Feb 1, 2023
natalieparellano
commented
Feb 1, 2023
natalieparellano
commented
Feb 1, 2023
natalieparellano
commented
Feb 1, 2023
Signed-off-by: Natalie Arellano <narellano@vmware.com>
f153892
to
b448d5e
Compare
…t run.toml Signed-off-by: Natalie Arellano <narellano@vmware.com>
b448d5e
to
ef56944
Compare
This was referenced Feb 2, 2023
natalieparellano
commented
Feb 6, 2023
natalieparellano
commented
Feb 6, 2023
natalieparellano
commented
Feb 6, 2023
jkutner
reviewed
Feb 7, 2023
jkutner
reviewed
Feb 7, 2023
Co-authored-by: Joe Kutner <jpkutner@gmail.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
10 tasks
BarDweller
reviewed
Mar 31, 2023
natalieparellano
commented
Jun 5, 2023
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
jkutner
approved these changes
Jul 14, 2023
Signed-off-by: Natalie Arellano <narellano@vmware.com>
hone
reviewed
Jul 24, 2023
Signed-off-by: Natalie Arellano <narellano@vmware.com>
hone
approved these changes
Jul 24, 2023
This is needed when extensions were used to switch (but not extend) the run image and we need to re-read the target data from the image config. In such cases, we don't need the run image to exist in a registry, because we don't need a manifest for kaniko. Signed-off-by: Natalie Arellano <narellano@vmware.com>
@hone I added one more: 8581965 For further context, see: buildpacks/pack#1850 (comment) |
This was referenced Jul 31, 2023
hone
approved these changes
Aug 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branching off of stack removal for the time being