Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform API changes for run image extension (Dockerfiles phase 3) #347

Merged
merged 14 commits into from
Aug 1, 2023
Merged

Platform API changes for run image extension (Dockerfiles phase 3) #347

merged 14 commits into from
Aug 1, 2023

Conversation

natalieparellano
Copy link
Member

Branching off of stack removal for the time being

@natalieparellano natalieparellano requested a review from a team as a code owner January 26, 2023 19:55
@natalieparellano natalieparellano marked this pull request as draft January 26, 2023 19:55
natalieparellano
natalieparellano commented Jan 26, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jan 26, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jan 26, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jan 26, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano natalieparellano changed the title Platform API changes for run image extension Platform API changes for run image extension (Dockerfiles phase 3) Feb 1, 2023
natalieparellano
natalieparellano commented Feb 1, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Feb 1, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Feb 1, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Feb 1, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Feb 1, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Feb 1, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano
Add run image extension to platform spec as per RFC 0105
156a812 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano force-pushed the run-image-extension/platform branch 2 times, most recently from f153892 to b448d5e Compare February 2, 2023 22:35
@natalieparellano
Rename stack.toml to run.toml and validate run image selection agains…
ef56944 
…t run.toml

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano marked this pull request as ready for review February 2, 2023 22:40
This was referenced Feb 2, 2023
Open
Merged
natalieparellano
natalieparellano commented Feb 6, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Feb 6, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
jkutner
jkutner reviewed Feb 7, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
jkutner
jkutner reviewed Feb 7, 2023
View reviewed changes
platform.md Show resolved Hide resolved
@natalieparellano @jkutner
Apply suggestions from code review
9828bf3 
Co-authored-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
natalieparellano commented Mar 28, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Mar 28, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano natalieparellano mentioned this pull request Mar 31, 2023
Closed
10 tasks
BarDweller
BarDweller reviewed Mar 31, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Apr 13, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jun 5, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano
Update platform.md
910c3de 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Update analyzed.toml description
3deb450 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Merge branch 'stack-removal/platform' into run-image-extension/platform
b0ccf7c 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member Author

natalieparellano commented Jul 24, 2023 •
edited

@hone could I get your 👀 on this one?

Note that it is still branching off of stack-removal/platform, to make the diff easier to parse. We should probably merge #335 before re-pointing this to platform/0.10.

hone
hone reviewed Jul 24, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jul 24, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano
Update platform.md
b4f9539 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Add -daemon to restorer
8581965 
This is needed when extensions were used to switch (but not extend) the run image
and we need to re-read the target data from the image config.

In such cases, we don't need the run image to exist in a registry,
because we don't need a manifest for kaniko.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member Author

@hone I added one more: 8581965

For further context, see: buildpacks/pack#1850 (comment)

This was referenced Jul 31, 2023
Merged
Merged
Base automatically changed from stack-removal/platform to platform/0.12 August 1, 2023 15:57
@natalieparellano natalieparellano merged commit 42c59ca into platform/0.12 Aug 1, 2023
1 check passed
@natalieparellano natalieparellano deleted the run-image-extension/platform branch August 1, 2023 16:37
@natalieparellano natalieparellano mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarDweller BarDweller BarDweller left review comments

@jkutner jkutner jkutner approved these changes

@hone hone hone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@natalieparellano @jkutner @hone @BarDweller