Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ActionText values for jbuilder-schema #681

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

newstler
Copy link
Contributor

@newstler newstler commented Nov 17, 2023

Fixes #680
Fixes bullet-train-co/jbuilder-schema#74

It also updates jbuilder-schema version to 2.6.6, where ActionText issue has been fixed.

@newstler
Copy link
Contributor Author

newstler commented Nov 29, 2023

@jagthedrummer Seems we fixed the issue with Template requirement, if we get this PR merged we can check bullet-train-co/jbuilder-schema#73 and if everything's ok merge it too! The changes you requested I don't know how to mark I applied them, sorry 😅
Also not sure why bundle setup is failing, as I added Gemfile.lock to the PR and rebased on top of main...

@newstler newstler force-pushed the fixes/values_transformer_for_schema branch from 881cf2a to 90c00ba Compare November 29, 2023 17:56
@jagthedrummer
Copy link
Contributor

@newstler, I think the failures are due to us not having all of our dependencies between the core gems defined as explicitly as we should. I'm going to be out for the next couple of days, but next week I'll work on getting those dependency issues resolved so that we can get this merged.

@jagthedrummer jagthedrummer merged commit a295b81 into main Dec 4, 2023
30 checks passed
@jagthedrummer jagthedrummer deleted the fixes/values_transformer_for_schema branch December 4, 2023 16:54
@jagthedrummer
Copy link
Contributor

Getting our entire dependency graph sorted out is going to be a bigish job. For now I just updated the Gemfile.lock in each of the core gems that needs it so we can merge this and get moving again. I'll try to tackle the dependency thing this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants