Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job for testing against the starter repo #73

Merged
merged 69 commits into from
Dec 4, 2023

Conversation

jagthedrummer
Copy link
Contributor

@jagthedrummer jagthedrummer commented Nov 17, 2023

This make it so that the GitHub Actions CI pipeline will:

  • Checkout the starter repo. We'll look for a branch on the starter repo that matches the name of the branch being tested. If we can't find one we'll test against the main branch.
  • Checkout the core repo, also looking for a matching branch.
  • Alter the Gemfile in the starter repo to point to the local branch of jbuilder-schema and the core gems.
  • Run the Minitest suite of the starter repo
  • Run the Super Scaffolding suite of the starter repo Edit: I'm not sure it's useful to run the Super Scaffolding tests, so I'm skipping it for now.

@jagthedrummer
Copy link
Contributor Author

@newstler This should be good to go for running tests against the starter repo. There's one test failing on this PR related to #74 but this doesn't change any shipped code so it should be safe to merge.

@newstler
Copy link
Contributor

@jagthedrummer How urgent is this? I would wait when #74 is resolved if possible (we're looking for solution with @kaspth) to be able to release next versions with green tests.

@jagthedrummer
Copy link
Contributor Author

@newstler not super urgent. I just figured that we should get this going sooner rather than later since we kept finding issues after a release instead of before.

This make it so that the GitHub Actions CI pipeline will:

* Checkout the starter repo. We'll look for a branch on the starter repo
  that matches the name of the branch being tested. If we can't find one
  we'll test against the `main` branch.
* Checkout the `core` repo, also looking for a matching branch.
* Alter the `Gemfile` in the starter repo to point to the local branch
  of `jbuilder-schema` and the `core` gems.
* Run the Minitest suite of the starter repo
* Run the Super Scaffolding suite of the starter repo
@jagthedrummer jagthedrummer force-pushed the jeremy/bullet-train-starter-repo-tests branch from 86caf02 to 7c3457e Compare December 4, 2023 16:55
@jagthedrummer
Copy link
Contributor Author

@newstler looks like #74 is now resolved, so I rebased this branch and now it looks like everything is good to go.

@newstler newstler merged commit 47986f2 into main Dec 4, 2023
11 checks passed
@newstler
Copy link
Contributor

newstler commented Dec 4, 2023

@jagthedrummer Released this as v2.6.7 so should be good to check in BT gems without updating the minor version number there again.

@newstler newstler deleted the jeremy/bullet-train-starter-repo-tests branch March 22, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants