Skip to content

Commit

Permalink
enhance RNTester android config
Browse files Browse the repository at this point in the history
Summary:
* cliPath is not config right
* root config can be better config instead of a relative path which can easily go wrong if location changed
* DeveloperSupport should only be in debug mode.

* make facebook#18732 change on local.
* config signingConfig
* execute `./gradlew :RNTester:android:app:assembleRelease`, and run app on device to check everything is fine.

none

[GENERAL][ENHANCEMENT][RNTester]
Closes facebook#18746

Differential Revision: D7548846

Pulled By: hramos

fbshipit-source-id: 8943f84a6c99456477dff2deeaacc96f093b2e09
  • Loading branch information
gengjiawen authored and bunnyc1986 committed May 11, 2018
1 parent 56504d5 commit a10a401
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion RNTester/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,10 @@ import com.android.build.OutputFile
*/

project.ext.react = [
cliPath: "$rootDir/local-cli/cli.js",
bundleAssetName: "RNTesterApp.android.bundle",
entryFile: file("../../js/RNTesterApp.android.js"),
root: "../../../",
root: "$rootDir",
inputExcludes: ["android/**", "./**"]
]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public String getJSMainModuleName() {

@Override
public boolean getUseDeveloperSupport() {
return true;
return BuildConfig.DEBUG;
}

@Override
Expand Down

0 comments on commit a10a401

Please sign in to comment.