enhance RNTester android config #18746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Missing Changelog
|
Looks good, thanks! @facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
janicduplessis
approved these changes
Apr 8, 2018
facebook-github-bot
approved these changes
Apr 8, 2018
There was a problem hiding this comment.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
campsafari
pushed a commit
to exozet/react-native
that referenced
this pull request
Apr 11, 2018
Summary: * cliPath is not config right * root config can be better config instead of a relative path which can easily go wrong if location changed * DeveloperSupport should only be in debug mode. * make facebook#18732 change on local. * config signingConfig * execute `./gradlew :RNTester:android:app:assembleRelease`, and run app on device to check everything is fine. none [GENERAL][ENHANCEMENT][RNTester] Closes facebook#18746 Differential Revision: D7548846 Pulled By: hramos fbshipit-source-id: 8943f84a6c99456477dff2deeaacc96f093b2e09
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: * cliPath is not config right * root config can be better config instead of a relative path which can easily go wrong if location changed * DeveloperSupport should only be in debug mode. * make facebook#18732 change on local. * config signingConfig * execute `./gradlew :RNTester:android:app:assembleRelease`, and run app on device to check everything is fine. none [GENERAL][ENHANCEMENT][RNTester] Closes facebook#18746 Differential Revision: D7548846 Pulled By: hramos fbshipit-source-id: 8943f84a6c99456477dff2deeaacc96f093b2e09
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: * cliPath is not config right * root config can be better config instead of a relative path which can easily go wrong if location changed * DeveloperSupport should only be in debug mode. * make facebook#18732 change on local. * config signingConfig * execute `./gradlew :RNTester:android:app:assembleRelease`, and run app on device to check everything is fine. none [GENERAL][ENHANCEMENT][RNTester] Closes facebook#18746 Differential Revision: D7548846 Pulled By: hramos fbshipit-source-id: 8943f84a6c99456477dff2deeaacc96f093b2e09
bunnyc1986
pushed a commit
to bunnyc1986/react-native
that referenced
this pull request
May 11, 2018
Summary: * cliPath is not config right * root config can be better config instead of a relative path which can easily go wrong if location changed * DeveloperSupport should only be in debug mode. * make facebook#18732 change on local. * config signingConfig * execute `./gradlew :RNTester:android:app:assembleRelease`, and run app on device to check everything is fine. none [GENERAL][ENHANCEMENT][RNTester] Closes facebook#18746 Differential Revision: D7548846 Pulled By: hramos fbshipit-source-id: 8943f84a6c99456477dff2deeaacc96f093b2e09
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: * cliPath is not config right * root config can be better config instead of a relative path which can easily go wrong if location changed * DeveloperSupport should only be in debug mode. * make facebook#18732 change on local. * config signingConfig * execute `./gradlew :RNTester:android:app:assembleRelease`, and run app on device to check everything is fine. none [GENERAL][ENHANCEMENT][RNTester] Closes facebook#18746 Differential Revision: D7548846 Pulled By: hramos fbshipit-source-id: 8943f84a6c99456477dff2deeaacc96f093b2e09
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Aug 17, 2018
Summary: * cliPath is not config right * root config can be better config instead of a relative path which can easily go wrong if location changed * DeveloperSupport should only be in debug mode. * make facebook/react-native#18732 change on local. * config signingConfig * execute `./gradlew :RNTester:android:app:assembleRelease`, and run app on device to check everything is fine. none [GENERAL][ENHANCEMENT][RNTester] Closes facebook/react-native#18746 Differential Revision: D7548846 Pulled By: hramos fbshipit-source-id: 8943f84a6c99456477dff2deeaacc96f093b2e09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test Plan
./gradlew :RNTester:android:app:assembleRelease, and run app on device to check everything is fine.Related PRs
none
Release Notes
[GENERAL][ENHANCEMENT][RNTester]