Fix/update-internal-properties

[alifeee]

Changes discussed in #881

gspread.Worksheet._properties (and thus the gspread.Worksheet @property fields) are now updated whenever the following are called (as well as previous changes):

• append_rows
• insert_rows
• insert_cols
• delete_dimension

(as you can see, the leftover was mostly gspread.Worksheet.row_count and [...].col_count

also new tests added for insert_cols and delete_cols (before, only row tests existed)

[alifeee]

Final thoughts: we should consider if gspread.Spreadsheet has any internal properties that are not updated, in a similar vein. On a brief look, there are:

• id
• title
• url
• creationTime
• lastUpdateTime
• updated
• timeZone
• locale
• sheet1

These are not updated on property change. I see:

• id, creationTime are never updated (or shouldn't be?)
• title, timeZone, locale should be easy fixes (I will do these in Fix/update-internal-properties #1225)
• I have not looked at the implementation of lastUpdateTime, but it seems like it would be complex to update. Perhaps an extra API call makes sense for this one (but then as a method rather than a @property - deprecate the property?)
• sheet1, url, updated do not directly depend on _properties so can be ignored

[alifeee]

(based on comment #881 (comment))

closes #881

[alifeee]

looks the only methods we may have to edit are

• gspread.Spreadsheet.update_title
• gspread.Spreadsheet.update_timezone
• gspread.Spreadsheet.update_locale

I will do this soon.

and then the discussion of lastUpdateTime above - require @lavigne958 thoughts.

[alifeee]

ok, done title, timezone, & locale

it is ready to merge now, just after wondering whether lastUpdatedTime should change. Current implementation:

gspread/gspread/spreadsheet.py

Lines 62 to 70 in 20a2209

	@property
	def lastUpdateTime(self):
	"""Spreadsheet last updated time."""
	try:
	return self._properties["modifiedTime"]
	except KeyError:
	metadata = self.client._get_file_drive_metadata(self.id)
	self._properties.update(metadata)
	return self._properties["modifiedTime"]

So it runs an API request if it is not already in _properties. Due to the nature of the property, it might be nice to run the API request every time, so that it is always up to date. However, this may be better suited to a function, i.e. getLastUpdatedTime(), so it's more obvious the API is used. Thoughts?

[lavigne958]

That's hard to say, currently we request it if not present but as you mention it's not updated.

To me we could add a new method like you said getLastUpdatedTime but instead of get we coudl make it actually update the last update time, kind of like retrieve the last update time. this makes it obvious that the method makes an API call then the user still uses the property to get it.

In a way we provide a way to update the property.

does that makes sense ? this way we can add it to the next release using the current PR without breaking anything.