Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update-internal-properties #1225

Merged
merged 14 commits into from
Jun 16, 2023
Merged

Fix/update-internal-properties #1225

merged 14 commits into from
Jun 16, 2023

Commits on Jun 15, 2023

  1. update _properties for append_rows

    @alifeee
    alifeee committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    9cbe1d9 View commit details
    Browse the repository at this point in the history

  2. update _properties for insert_rows

    @alifeee
    alifeee committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c0963c6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix/update-internal-properties

    @alifeee
    alifeee committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    7d01370 View commit details
    Browse the repository at this point in the history

  4. add test_insert_cols

    @alifeee
    alifeee committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    4914fba View commit details
    Browse the repository at this point in the history

  5. update _properties for insert_cols

    @alifeee
    alifeee committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    573f7b2 View commit details
    Browse the repository at this point in the history

  6. update _properties for delete_rows

    @alifeee
    alifeee committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    da06507 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. add test_delete_cols

    @alifeee
    alifeee committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    505b8fd View commit details
    Browse the repository at this point in the history

  2. update _properties for delete_dimension

    @alifeee
    alifeee committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    5de2996 View commit details
    Browse the repository at this point in the history

  3. fix index error for delete_rows 

    (oops)
was not aware of implementation
I thought end_index was the row *after* the last deleted row
    @alifeee
    alifeee committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    8cc6793 View commit details
    Browse the repository at this point in the history

  4. remove props update in delete_rows 

    it is handled by `delete_dimension`
(was being duplicated)
    @alifeee
    alifeee committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    47b724e View commit details
    Browse the repository at this point in the history

  5. rename response res for consistency

    @alifeee
    alifeee committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    c8591d1 View commit details
    Browse the repository at this point in the history

  6. update _properties for update_timezone

    @alifeee
    alifeee committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    ba00a83 View commit details
    Browse the repository at this point in the history

  7. update _properties for update_locale

    @alifeee
    alifeee committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    3435485 View commit details
    Browse the repository at this point in the history

  8. add regression tests

    @alifeee
    alifeee committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a826044 View commit details
    Browse the repository at this point in the history