This repository has been archived by the owner on Mar 17, 2023. It is now read-only.
Avoid chunk argument #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| state[:sum] = object.size | ||
| state[:index] += 1 | ||
| sum = 0 | ||
| index = 0 |
There was a problem hiding this comment.
I prefer the current format. #wontfix
bjorne
force-pushed
the
avoid-chunk-argument
branch
2 times, most recently
from
b520ded to
0f13782
Compare
The argument to Enumerable#chunk was removed in 2.3: > * enum.c: Enumerable#chunk and Enumerable#slice_before no longer takes > the initial_state argument. [Feature #10958]
Should be fine since we in practive only invoke #chunk once.
bjorne
force-pushed
the
avoid-chunk-argument
branch
from
5847d30 to
c60e3af
Compare
The chunking performed within RestorePlan#price and Cli#restore was inconsistent. This did not show because of the memoization that existed previously.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument to Enumerable#chunk was removed in 2.3:
This also adds 2.3.1 to the Travis build matrix.