Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Closes #3558 #3559

Closed
wants to merge 1 commit into from
Closed

Closes #3558 #3559

wants to merge 1 commit into from

Conversation

digitalextremist
Copy link

ruby-head seems to be more strict about how instance variables are referenced, at the moment.

@digitalextremist digitalextremist mentioned this pull request Apr 11, 2015
Closed
@segiddins
Copy link
Member

I believe this is actually caused by rubygems/rubygems@620910a.

digitalextremist referenced this pull request in rubygems/rubygems Apr 11, 2015
@tenderlove
remove extra caching on spec
620910a 
The package object already caches the spec object, so we don't need to
do it multiple times.  Also introduce a consturctor for in-memory
installations so that we can rm the `spec` setter method
@segiddins
Copy link
Member

@digitalextremist this PR doesn't seem to fix things, please take a look at the test failures?

@digitalextremist
Copy link
Author

@segiddins seeing the test failures, but at first glance it seems like it's failing on tests not anticipating @tenderlove's changes to rubygems. Looking further.

@digitalextremist
Copy link
Author

@segiddins the give-away that this is more about how an instance variable is referenced versus whether caching is being done, for me, is that this is ruby-head isolated so far.

@segiddins
Copy link
Member

well, does adding an attr_accessor :spec fix things?

On Apr 10, 2015, at 9:58 PM, digitalextremist notifications@github.com wrote:

@segiddins https://github.com/segiddins the give-away that this is more about how an instance variable is referenced versus whether caching is being done, for me, is that this is ruby-head isolated so far.

—
Reply to this email directly or view it on GitHub #3559 (comment).

@digitalextremist
Copy link
Author

I pulled my comment from @tenderlove's commit since it was out of the context of that commit, and I'm looking through rubygems right now to attempt putting @spec within scope of its own instances which reference it as spec .. purely for science, because you asked. As far as I can see, what you're talking about is another similar issue.

@indirect
Copy link
Member

I have basically no idea what is even going on here. What is broken, and under what circumstances? What is this patch supposed to fix, and why does the change make the tests fail?

@indirect
Copy link
Member

This is fixed by f4481a7.

@indirect indirect closed this Apr 11, 2015
@trusche trusche mentioned this pull request Dec 6, 2015
Closed
@yuya-takeyama yuya-takeyama mentioned this pull request Dec 16, 2015
Merged
yuya-takeyama added a commit to woothee/woothee-ruby that referenced this pull request Dec 16, 2015
@yuya-takeyama
Update bundler to fix installation issue
ba33e09 
ref: rubygems/bundler#3559
@ghost ghost mentioned this pull request Dec 16, 2015
Merged
dmerrick pushed a commit to plaid/plaid-ruby that referenced this pull request Dec 16, 2015
Using a more recent version of bundler.
c791ed1 
To fix issues with TravisCI.
c.p. rubygems/bundler#3559
This was referenced Dec 28, 2015
Merged
Merged
Merged
Merged
@tmaier tmaier mentioned this pull request Jan 1, 2016
Merged
grosser added a commit to grosser/maxitest that referenced this pull request Jan 7, 2016
@grosser
fix rubygems/bundler#3559
296d7e8
grosser added a commit to grosser/maxitest that referenced this pull request Jan 7, 2016
@grosser
Merge pull request #12 from grosser/grosser/fix
a61f002 
fix rubygems/bundler#3559
@san650 san650 mentioned this pull request Jan 14, 2016
Merged
@langalex langalex mentioned this pull request Jan 19, 2016
Merged
@andrewsomething andrewsomething mentioned this pull request Jan 28, 2016
Merged
@pseudomuto pseudomuto mentioned this pull request Feb 1, 2016
Merged
janfoeh added a commit to etventure/sinatra-param that referenced this pull request Feb 2, 2016
@janfoeh
fixes Travis build failing by updating Bundler
46d3ad7 
see travis-ci/travis-ci#5239
and rubygems/bundler#3559
@sid77 sid77 mentioned this pull request Feb 8, 2016
Merged
@shepmaster shepmaster mentioned this pull request Mar 25, 2016
Merged
ljkbennett pushed a commit to ljkbennett/stub_env that referenced this pull request Mar 29, 2016
chore(setup): Add ci targets and fix bundler issue in 1.9.3
26c7529 
Install bundler explicitly to avoid rubygems/bundler#3559

Also test on newer versions of ruby
@jeremy jeremy mentioned this pull request Apr 18, 2016
Closed
jeremy added a commit to jeremy/rack that referenced this pull request Apr 18, 2016
@jeremy
CI: Refresh and repair builds
b7d872d 
* Fix incompatible backported specs
* Pin to Rake < 11.0 for 1.8 compat
* Upgrade Bundler to fix ye olde rubygems/bundler#3559
* Build on Ruby 2.3
* Allow failures on jruby-head and rbx-2
jeremy added a commit to jeremy/rack that referenced this pull request Apr 18, 2016
@jeremy
CI: Refresh and repair builds
3a0bde3 
* Fix incompatible backported specs
* Pin to Rake < 11.0 for 1.8 compat
* Switch to Travis container builds for newer Bundler
  * Fixes ye olde rubygems/bundler#3559
  * Allows us to use Bundler caching for faster builds
* Build on Ruby 2.3
* Allow failures on jruby-head and rbx-2
jeremy added a commit to jeremy/rack that referenced this pull request Apr 18, 2016
@jeremy
CI: Refresh and repair builds
b60860a 
* Fix incompatible backported specs
* Pin to Rake < 11.0 for 1.8 compat
* Switch to Travis container builds for newer Bundler
  * Fixes ye olde rubygems/bundler#3559
  * Allows us to use Bundler caching for faster builds
  * No longer needs sudo to manage packages
* Build on Ruby 2.3
* Allow failures on jruby-head and rbx-2
jeremy added a commit to jeremy/rack that referenced this pull request Apr 18, 2016
@jeremy
CI: Refresh and repair builds
37b1f20 
* Fix incompatible backported specs
* Pin to Rake < 11.0 for 1.8 compat
* Switch to Travis container builds for newer Bundler
  * Fixes ye olde rubygems/bundler#3559
  * Allows us to use Bundler caching for faster builds
  * No longer needs sudo to manage packages
* Build on Ruby 2.3
* Allow failures on jruby-head and rbx-2
jeremy added a commit to jeremy/rack that referenced this pull request Apr 18, 2016
@jeremy
CI: Refresh and repair builds
76a5aa5 
* Fix incompatible backported specs
* Pin to Rake < 11.0 for 1.8 compat
* Switch to Travis container builds for newer Bundler
  * Fixes ye olde rubygems/bundler#3559
  * Allows us to use Bundler caching for faster builds
  * No longer needs sudo to manage packages
* Build on Ruby 2.3
* Allow failures on jruby-head and rbx-2
jeremy added a commit to jeremy/rack that referenced this pull request Apr 18, 2016
@jeremy
CI: Refresh and repair builds
b22e4fe 
* Fix incompatible backported specs
* Pin to Rake < 11.0 for 1.8 compat
* Switch to Travis container builds for newer Bundler
  * Fixes ye olde rubygems/bundler#3559
  * Allows us to use Bundler caching for faster builds
  * No longer needs sudo to manage packages
* Build on Ruby 2.3
* Allow failures on jruby-head and rbx-2
jeremy added a commit to jeremy/rack that referenced this pull request Apr 18, 2016
@jeremy
CI: Refresh and repair builds
6ec4578 
* Fix incompatible backported specs
* Pin to Rake < 11.0 for 1.8 compat
* Switch to Travis container builds for newer Bundler
  * Fixes ye olde rubygems/bundler#3559
  * Allows us to use Bundler caching for faster builds
  * No longer needs sudo to manage packages
* Build on Ruby 2.3
* Allow failures on jruby-head and rbx-2
jeremy added a commit to jeremy/rack that referenced this pull request Apr 18, 2016
@jeremy
CI: Refresh and repair builds
c8fbe0a 
* Fix incompatible backported specs
* Pin to Rake < 11.0 for 1.8 compat
* Switch to Travis container builds for newer Bundler
  * Fixes ye olde rubygems/bundler#3559
  * Allows us to use Bundler caching for faster builds
  * No longer needs sudo to manage packages
* Build on Ruby 2.3
* Allow failures on jruby-head and rbx-2
jeremy added a commit to jeremy/rack that referenced this pull request Apr 18, 2016
@jeremy
CI: Refresh and repair builds
77f55e9 
* Fix incompatible backported specs
* Pin to Rake < 11.0 for 1.8 compat
* Switch to Travis container builds for newer Bundler
  * Fixes ye olde rubygems/bundler#3559
  * Allows us to use Bundler caching for faster builds
  * No longer needs sudo to manage packages
* Build on Ruby 2.3
* Allow failures on jruby-head and rbx-2
jeremy added a commit to jeremy/rack that referenced this pull request Apr 18, 2016
@jeremy
CI: Refresh and repair builds
7d70d24 
* Fix incompatible backported specs
* Pin to Rake < 11.0 for 1.8 compat
* Switch to Travis container builds for newer Bundler
  * Fixes ye olde rubygems/bundler#3559
  * Allows us to use Bundler caching for faster builds
  * No longer needs sudo to manage packages
* Build on Ruby 2.3
* Allow failures on jruby-head and rbx-2
jeremy added a commit to jeremy/rack that referenced this pull request Apr 18, 2016
@jeremy
CI: Refresh and repair builds
6df2963 
* Fix incompatible backported specs
* Pin to Rake < 11.0 for 1.8 compat
* Switch to Travis container builds for newer Bundler
  * Fixes ye olde rubygems/bundler#3559
  * Allows us to use Bundler caching for faster builds
  * No longer needs sudo to manage packages
* Build on Ruby 2.3
* Allow failures on jruby-head and rbx-2
jkeck added a commit to sul-dlss/dor-rights-auth that referenced this pull request May 20, 2016
@jkeck
Update bundler before running travis build due to a known issue with …
ae9e67c 
…having an outdated version of bundler on travis.

See rubygems/bundler#3559
schneems added a commit to zombocom/get_process_mem that referenced this pull request Jun 1, 2016
@schneems
fix travis?
9c7d7df 
Builds are hitting this issue rubygems/bundler#3559

Example https://travis-ci.org/schneems/get_process_mem/jobs/134455148

```
Bundler version 1.7.6
$ gem --version
2.5.1
11.90s$ bundle install --jobs=3 --retry=3
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Installing sys-proctable 1.0.0
Installing rake 10.5.0
Using bundler 1.7.6
NoMethodError: undefined method `spec' for nil:NilClass
Installing power_assert 0.3.0
An error occurred while installing get_process_mem (0.2.1), and Bundler cannot
continue.
Make sure that `gem install get_process_mem -v '0.2.1'` succeeds before
```
@Darunada Darunada mentioned this pull request Jun 18, 2016
Open
bjorne added a commit to burtcorp/tina that referenced this pull request Jul 19, 2016
@bjorne
Update bundler on travis
b8d1329 
See:
* rubygems/bundler#3559
* rubygems/rubygems#1419
* travis-ci/travis-ci#3531
bjorne added a commit to burtcorp/tina that referenced this pull request Jul 19, 2016
@bjorne
Update bundler on travis
f7e669a 
See:
* rubygems/bundler#3559
* rubygems/rubygems#1419
* travis-ci/travis-ci#3531
@marcoow marcoow mentioned this pull request Jan 2, 2017
Merged
adrianbn pushed a commit to adrianbn/sinatra-param2 that referenced this pull request Jun 4, 2017
@janfoeh @adrianbn
allows :in, :within, :range validations to be used on Array params
15fbd9e 
fixes Travis build failing by updating Bundler

see travis-ci/travis-ci#5239
and rubygems/bundler#3559
adrianbn added a commit to adrianbn/sinatra-param2 that referenced this pull request Jun 4, 2017
@adrianbn
allows :in, :within, :range validations to be used on Array params (#6)
981875d 
fixes Travis build failing by updating Bundler

see travis-ci/travis-ci#5239
and rubygems/bundler#3559
@otoyo otoyo mentioned this pull request Sep 9, 2017
Merged
jeremy added a commit to mikel/mail that referenced this pull request Sep 13, 2017
@jeremy
CI: upgrade bundler to work around rubygems/bundler#3559
9972f05
lanej added a commit to fog/fog-aws that referenced this pull request Sep 25, 2017
@lanej
bundler ~> 1.15
2c71bdf 
Fixes rubygems/bundler#3559
@lanej lanej mentioned this pull request Sep 25, 2017
Merged
lollipopman added a commit to braintree/litmus_paper that referenced this pull request Oct 3, 2017
@lollipopman
upgrade bundler, to solve rubygems/bundler#3559
035cac0
@gordonbondon gordonbondon mentioned this pull request Oct 17, 2017
Open
starbeast pushed a commit to engineyard/fog-aws that referenced this pull request Dec 8, 2017
@lanej @starbeast
bundler ~> 1.15
dfe1c5f 
Fixes rubygems/bundler#3559
@jaydorsey jaydorsey mentioned this pull request Feb 12, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@digitalextremist @segiddins @indirect