Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.3.0 and frozen_string_literal magic comment #70

Merged
merged 5 commits into from
Jan 4, 2016

Conversation

tmaier
Copy link
Member

@tmaier tmaier commented Jan 1, 2016

  • Adds ruby 2.3.0 for Travis CI tests
  • Updates all ruby versions specified for Travis CI tests to be in-line with versions supported by Heroku
  • Add # frozen_string_literal: true to all ruby files to freeze all strings

FAQ

Did you actually test/measure any performance improvement by this change?

Nope.

Did you run the tests?

$ bundle exec rake was successful.

Did you add the magic comments manually?

No, I used https://github.com/Invoca/magic_frozen_string_literal

@tmaier
Copy link
Member Author

tmaier commented Jan 1, 2016

Alright, the build fails on Ruby 1.9.3. This seems to be related to rubygems/bundler#3559.

Two options:

  1. Install the latest bundler version on travis as a workaround
  2. drop support for Ruby 1.9.3. This ruby version is anyway not maintained anymore.

Which one do you prefer?

@tmaier
Copy link
Member Author

tmaier commented Jan 1, 2016

Issue with Ruby 1.9.3 seems to be resolved when using Travis CIs container based infrastructure.

@geemus
Copy link
Member

geemus commented Jan 4, 2016

Thanks!

geemus added a commit that referenced this pull request Jan 4, 2016
Ruby 2.3.0 and frozen_string_literal magic comment
@geemus geemus merged commit e7957be into interagent:master Jan 4, 2016
@tmaier tmaier deleted the tmaier-2.3.0-is-magic branch January 5, 2016 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants