-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imputation initial demo #562
base: master
Are you sure you want to change the base?
Imputation initial demo #562
Conversation
Important Review skippedReview was skipped as selected files did not have any reviewable changes. Files selected but had no reviewable changes (1)
You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Thanks! Will take a look in the morning |
"from sklearn.metrics import mean_squared_error\n", | ||
"\n", | ||
"import sys\n", | ||
"sys.path.append('/home/austin/Forks/bystro/python/python/bystro/imputation/fancyimpute/')\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove hardcoded paths. For files that you want available to users, we can add them to our s3 bucket, just send them to me, and I will give you the path.
fancy impute doesn't seem to be used? (from soft_impute import SoftImpute). Did you mean from fancy impute import SoftImpute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ate fancyimpute for some of our methods which we have as a subdirectory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove hardcoded paths
This demonstrates to users how to impute missing data.