-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPI package does not work on Alpine #237
Comments
Is there a python target which is "not glibc" and/or "only musl libc"? Or would all linux users need to switch over to a musl-based version? I'll also note that we haven't yet added musl/alpine releases for Wasmtime itself and this repo pulls from the artifacts produced in Wasmtime itself so that might be a prerequisite here too |
It's |
This was requested in bytecodealliance/wasmtime-py#237 and shouldn't cost us too much in terms of CI resources and maintenance overhead.
Nice! I believe with that there'd be a new addition of @whitequark do you need any other platforms other than x86_64? It'll be significantly more difficult getting other musl-based architectures working since we'd have to build our own toolchain which is generally not an easy thing to architect for CI |
This was requested in bytecodealliance/wasmtime-py#237 and shouldn't cost us too much in terms of CI resources and maintenance overhead.
That should cover the vast majority of use cases. I can see someone wanting arm64 for Alpine on Apple M1 eventually, but that's a niche of a niche and I don't think we need to care about this now. Thanks! |
* Add release binaries for x86_64-musl This was requested in bytecodealliance/wasmtime-py#237 and shouldn't cost us too much in terms of CI resources and maintenance overhead. * Fix combining rustflags prtest:full
Use binaries from bytecodealliance/wasmtime#8668 to add a musl wheel. cc bytecodealliance#237
* Add a wheel for `musllinux_1_2_x86_64` Use binaries from bytecodealliance/wasmtime#8668 to add a musl wheel. cc #237 * Fix download script * Comment different version of version used for musl * Simplify installation of wasm-tools on CI * Don't cache the registry any more Cargo's default heuristics nowadays are better than the caching. * Update some github actions versions
@whitequark can you test this release and see if it works for you? |
@alexcrichton tested, can verify that it works for me :) |
Awesome, thanks! Is this something where you'd like to see that as a 21.0.1 release? Or is waiting until |
(Do you mean June?) |
Oops sorry, yes, I mean June. |
I think that's fine--we get folks on musl-based distros occasionally but it's not a lot and you don't need to go through the trouble of making a release. Thanks for offering! (I guess this issue could be closed once there's a release?) |
To reproduce:
The root cause is that the
manylinux
wheels that are currently published are based on glibc, but Alpine is based on musl libc. There is a separatemusllinux
platform tag that can be used in that case.Do you think musl-compatible builds could be added? This would improve compatibility with certain distributions like Alphine Linux, Void Linux, and others focusing on size and speed.
The text was updated successfully, but these errors were encountered: