-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release binaries for x86_64-musl #8668
Add release binaries for x86_64-musl #8668
Conversation
This was requested in bytecodealliance/wasmtime-py#237 and shouldn't cost us too much in terms of CI resources and maintenance overhead.
prtest:full
Thanks again =^__^= This will improve the compatibility story for YoWASP and the Glasgow Interface Explorer to even more Linux distributions. |
Use binaries from bytecodealliance/wasmtime#8668 to add a musl wheel. cc bytecodealliance#237
* Add a wheel for `musllinux_1_2_x86_64` Use binaries from bytecodealliance/wasmtime#8668 to add a musl wheel. cc #237 * Fix download script * Comment different version of version used for musl * Simplify installation of wasm-tools on CI * Don't cache the registry any more Cargo's default heuristics nowadays are better than the caching. * Update some github actions versions
Hi @alexcrichton, I'm curious about a couple things here regarding musl support:
Thank you |
For usage in C we compile a wasmtime.so dynamic library. Producing a dynamic library is incompatible with statically linking libc. The musl based binaries also seem to be meant for usage on musl based distros where statically linking libc only has disadvantages. (bigger binaries, not getting security updates to libc) |
Is there anything that precludes compiling the static library version of the embedding (IE |
If you compile it yourself, I don't see why it shouldn't work. |
I think that the @bjorn3 is right though in that when building yourself you should have any option you need available to you for target/static linking/etc. |
Yeah it seemed to be working on my end; I used zig as the C toolchain so I get full static outputs by default. My questions were more regarding the statement Thank you both! |
This was requested in bytecodealliance/wasmtime-py#237 and shouldn't cost us too much in terms of CI resources and maintenance overhead.