Remove wasmtime link dep on libm #9100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prtest:full
pchickey
force-pushed
the
pch/musl_remove_libm_linkage
branch
from
0c63753 to
7126c7d
Compare
github-actions
bot
added
the
wasmtime:api
pchickey
requested review from
fitzgen and
alexcrichton
and removed request for
a team and
fitzgen
alexcrichton
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
CI overrides the linker with a musl-gcc install. I'm not sure why, ...
This is because our build containers are all Ubuntu so the default linker uses glibc instead of musl. The musl-gcc package is sort of a few wrapper scripts to tell the linker to link musl instead of glibc. In your distro it might be musl-based so this all happens by default perhaps?
In any case looks good to me, now I'm not sure why I needed this but maybe I got something wrong while developing this and accidentally thought it was required.
pchickey
pushed a commit
that referenced
this pull request
Aug 12, 2024
pchickey
pushed a commit
that referenced
this pull request
Aug 12, 2024
This was referenced Aug 12, 2024
alexcrichton
pushed a commit
that referenced
this pull request
Aug 12, 2024
alexcrichton
pushed a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #8668 but it doesn't appear to be necessary, and its presence breaks wasmtime-cli builds for x86_64-unknown-linux-musl on linux (tested with AWS2023, a redhat derivative) when using the default linker.
CI overrides the linker with a
musl-gccinstall. I'm not sure why, and at least in my project, we build without using the musl-gcc linker and everything works perfectly, and adopting that strategy broke something in a way I couldn't debug. So, I'd like it for CI to test the musl build with the default linker as well, to catch issues like this one. The CI matrix / docker configuration is pretty complicated and I was gonna consult with @alexcrichton on the best way to add this check.