Legalize fmin/fmax with NaN quieting semantics #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrown
force-pushed
the
legalize-fmin-fmax-slow
branch
from
6e1f8c3 to
3dda5bc
Compare
bjorn3
reviewed
Jun 19, 2020
abrown
force-pushed
the
legalize-fmin-fmax-slow
branch
from
3dda5bc to
7322f2e
Compare
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @bnjbvr
This issue or pull request has been labeled: "cranelift", "cranelift:meta"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
bnjbvr
approved these changes
Jun 25, 2020
| ) { | ||
| let ty = func.dfg.ctrl_typevar(inst); | ||
| debug_assert!(ty.is_vector()); | ||
| let (x, y, x86_opcode, is_max) = match func.dfg[inst] { |
There was a problem hiding this comment.
nit: Can we get rid of is_max by just looking at the opcode, instead of the one use of is_max?
There was a problem hiding this comment.
We could but then it would be let (x, y, x86_opcode, clif_opcode) and we would have to do the opcode comparison twice (once in the match and below in the current if using is_max).
There was a problem hiding this comment.
I'm going to merge this as-is but I can make a subsequent change to let (x, y, x86_opcode, clif_opcode) if you prefer that.
abrown
force-pushed
the
legalize-fmin-fmax-slow
branch
from
7322f2e to
2450111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is identical to #1821 but without the guarantee flags.