x64: Add test for a fixed issue #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a test from bytecodealliance#3337 which is an issue that was fixed in bytecodealliance#3506 due to moving `imul` lowering rules to ISLE which fixed the underlying issue of accidentally not falling through to the necessary case for general `i64x2.mul` multiplication. Closes bytecodealliance#3337
cfallin
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a test from #3337 which is an issue that was fixed
in #3506 due to moving
imullowering rules to ISLE which fixed theunderlying issue of accidentally not falling through to the necessary
case for general
i64x2.mulmultiplication.Closes #3337