Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen fix fcvt_from_sint.f32 with small types on riscv64. #5964

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Codegen fix fcvt_from_sint.f32 with small types on riscv64. #5964

merged 4 commits into from
Mar 10, 2023

Conversation

yuyang-ok
Copy link
Contributor

This will fix #5952.

@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Mar 8, 2023
@yuyang-ok yuyang-ok mentioned this pull request Mar 9, 2023
Closed
@yuyang-ok
Copy link
Contributor Author

@afonso360 I have move the code.

afonso360
afonso360 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@afonso360 afonso360 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I suspect we're going to need something similar for the other fcvt ops, But let's see what the fuzzer has to say about it.

@afonso360 afonso360 added this pull request to the merge queue Mar 10, 2023
Merged via the queue into bytecodealliance:main with commit 4e875f3 Mar 10, 2023
@jameysharp jameysharp mentioned this pull request Apr 5, 2023
Merged
@afonso360 afonso360 mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonso360 afonso360 afonso360 approved these changes

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cranelift: Wrong result for fcvt_from_sint.f32 on RISCV
2 participants
@yuyang-ok @afonso360