Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift: rewrite urem of constants #6048

Closed
wants to merge 1 commit into from

Conversation

Kmeakin
Copy link
Contributor

@Kmeakin Kmeakin commented Mar 17, 2023

;; x%1 == 0.
;; x%c == x&(c-1) when c is a power of 2.

Note these rules are currently dead, pending resolution of #5908

Note these rules are currently dead, pending resolution of
bytecodealliance#5908
@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Mar 17, 2023
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look correct to me; but on further thought, I think we should probably wait to merge until after we have the ability to execute the rule, otherwise we have untested/unfuzzed code waiting to be activated by another, distant infrastructure change. Do you mind if we leave this PR open until after #5908 is resolved somehow?

@Kmeakin
Copy link
Contributor Author

Kmeakin commented Mar 17, 2023

These look correct to me; but on further thought, I think we should probably wait to merge until after we have the ability to execute the rule, otherwise we have untested/unfuzzed code waiting to be activated by another, distant infrastructure change. Do you mind if we leave this PR open until after #5908 is resolved somehow?

No problem!

@github-actions github-actions bot added the isle Related to the ISLE domain-specific language label May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@Kmeakin Kmeakin closed this Jan 30, 2024
@Kmeakin Kmeakin deleted the rewrite-urem branch January 30, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants