Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift: rewrite urem of constants #6048

Closed
wants to merge 1 commit into from
Closed

cranelift: rewrite urem of constants #6048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cranelift/codegen/src/isle_prelude.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,11 @@ macro_rules! isle_common_prelude_methods {
}
}

#[inline]
fn u64_is_power_of_two(&mut self, x: u64) -> bool {
x.is_power_of_two()
}

#[inline]
fn u64_from_bool(&mut self, b: bool) -> u64 {
if b {
Expand Down
12 changes: 12 additions & 0 deletions cranelift/codegen/src/opts/algebraic.isle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
(subsume zero))

;; x/1 == x.
;; Currently not active: see issue #5908
(rule (simplify (sdiv ty
x
(iconst ty (u64_from_imm64 1))))
Expand All @@ -68,6 +69,17 @@
(iconst ty (u64_from_imm64 1))))
(subsume x))

;; x%1 == 0.
;; Currently not active: see issue #5908
(rule (simplify (urem ty x (iconst ty (u64_from_imm64 1))))
(subsume (iconst ty (imm64 0))))

;; x%c == x&(c-1) when c is a power of 2.
;; Currently not active: see issue #5908
(rule (simplify (urem ty x (iconst ty (u64_from_imm64 c))))
(if-let $true (u64_is_power_of_two c))
(band ty x (iconst ty (imm64 (u64_sub c 1)))))

;; x>>0 == x<<0 == x rotr 0 == x rotl 0 == x.
(rule (simplify (ishl ty
x
Expand Down
3 changes: 3 additions & 0 deletions cranelift/codegen/src/prelude.isle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@
(decl pure u64_is_odd (u64) bool)
(extern constructor u64_is_odd u64_is_odd)

(decl pure u64_is_power_of_two (u64) bool)
(extern constructor u64_is_power_of_two u64_is_power_of_two)

;;;; `cranelift_codegen::ir::Type` ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

(extern const $I8 Type)
Expand Down
18 changes: 18 additions & 0 deletions cranelift/filetests/filetests/egraph/algebraic.clif
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,24 @@ block0(v0: i32):
; check: return v2
}

function %urem_x_1(i32) -> i32 {
block0(v0: i32):
v1 = iconst.i32 1
v2 = urem v0, v1
return v2
; check: v1 = iconst.i32 1
; check: v2 = urem v0, v1
}

function %urem_x_pow2(i32) -> i32 {
block0(v0: i32):
v1 = iconst.i32 2
v2 = urem v0, v1
return v2
; check: v1 = iconst.i32 2
; check: v2 = urem v0, v1
}

function %or_and_y_with_not_y_i8(i8, i8) -> i8 {
block0(v0: i8, v1: i8):
v2 = band v0, v1
Expand Down