wasi-sockets: Simplify ip name lookup interface #7483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badeend
force-pushed
the
simplify-ip-name-lookup
branch
from
ce94830 to
8335773
Compare
- Remove the non-essential parameters - Lift the restriction against parsing IP addresses. Implementations would still have to parse IP addresses to decide whether or not to return an error
badeend
force-pushed
the
simplify-ip-name-lookup
branch
from
8335773 to
64944f5
Compare
alexcrichton
approved these changes
Nov 5, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
…nto simplify-ip-name-lookup
|
I've resolved the conflicts |
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 7, 2023
* Refactor ip_name_lookup test * Update ip-name-lookup::resolve-addresses - Remove the non-essential parameters - Lift the restriction against parsing IP addresses. Implementations would still have to parse IP addresses to decide whether or not to return an error * Deduplicate to_canonical
alexcrichton
added a commit
that referenced
this pull request
Nov 7, 2023
* Update wasm-tools dependencies (#7488) Pull in bytecodealliance/wasm-tools#1277 to switch the defaults for some WIT behaviors: * Semicolons are now required by default in WIT files * Wasm-encoded WIT packages now use the "new" format by default. WIT files without semicolons can still be parsed with `WIT_REQUIRE_SEMICOLONS=0`. The "old" format for wasm-encoded WIT packages can be emitted via `WIT_COMPONENT_ENCODING_V2=0`. Note that for wasm-encoded WIT packages both the old and the new format can be decoded irregardless of env vars. * wasi-sockets: Sync up UDP implementation & tests with TCP (#7423) * Refactor & move utilities. So that UDP can use them too. * Minor tweak in error code while connecting * Refactor: move portability workarounds out of the TCP implementation. * Sync up UDP implementation and tests based on the existing TCP implementation & tests. * Make test less flaky in CI. * wasi-sockets: Simplify ip name lookup interface (#7483) * Refactor ip_name_lookup test * Update ip-name-lookup::resolve-addresses - Remove the non-essential parameters - Lift the restriction against parsing IP addresses. Implementations would still have to parse IP addresses to decide whether or not to return an error * Deduplicate to_canonical * Add release notes for 15.0.0 (#7487) --------- Co-authored-by: Dave Bakker <github@davebakker.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify ip name lookup interface:
Related: #7013
FYI, the test includes a lookup to
münchen.deto test for internationalized domain names support. But it might be a bit weird to query this random, non-affiliated DNS server in the wasmtime CI. I tried looking for a standard testdomain (like example.com), but couldn't find any.