-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wasm-tools dependencies #7488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in bytecodealliance/wasm-tools#1277 to switch the defaults for some WIT behaviors: * Semicolons are now required by default in WIT files * Wasm-encoded WIT packages now use the "new" format by default. WIT files without semicolons can still be parsed with `WIT_REQUIRE_SEMICOLONS=0`. The "old" format for wasm-encoded WIT packages can be emitted via `WIT_COMPONENT_ENCODING_V2=0`. Note that for wasm-encoded WIT packages both the old and the new format can be decoded irregardless of env vars.
pchickey
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do you intend to backport these to 15?
Indeed! |
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 7, 2023
Pull in bytecodealliance/wasm-tools#1277 to switch the defaults for some WIT behaviors: * Semicolons are now required by default in WIT files * Wasm-encoded WIT packages now use the "new" format by default. WIT files without semicolons can still be parsed with `WIT_REQUIRE_SEMICOLONS=0`. The "old" format for wasm-encoded WIT packages can be emitted via `WIT_COMPONENT_ENCODING_V2=0`. Note that for wasm-encoded WIT packages both the old and the new format can be decoded irregardless of env vars.
alexcrichton
added a commit
that referenced
this pull request
Nov 7, 2023
* Update wasm-tools dependencies (#7488) Pull in bytecodealliance/wasm-tools#1277 to switch the defaults for some WIT behaviors: * Semicolons are now required by default in WIT files * Wasm-encoded WIT packages now use the "new" format by default. WIT files without semicolons can still be parsed with `WIT_REQUIRE_SEMICOLONS=0`. The "old" format for wasm-encoded WIT packages can be emitted via `WIT_COMPONENT_ENCODING_V2=0`. Note that for wasm-encoded WIT packages both the old and the new format can be decoded irregardless of env vars. * wasi-sockets: Sync up UDP implementation & tests with TCP (#7423) * Refactor & move utilities. So that UDP can use them too. * Minor tweak in error code while connecting * Refactor: move portability workarounds out of the TCP implementation. * Sync up UDP implementation and tests based on the existing TCP implementation & tests. * Make test less flaky in CI. * wasi-sockets: Simplify ip name lookup interface (#7483) * Refactor ip_name_lookup test * Update ip-name-lookup::resolve-addresses - Remove the non-essential parameters - Lift the restriction against parsing IP addresses. Implementations would still have to parse IP addresses to decide whether or not to return an error * Deduplicate to_canonical * Add release notes for 15.0.0 (#7487) --------- Co-authored-by: Dave Bakker <github@davebakker.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in bytecodealliance/wasm-tools#1277 to switch the defaults for some WIT behaviors:
WIT files without semicolons can still be parsed with
WIT_REQUIRE_SEMICOLONS=0
. The "old" format for wasm-encoded WIT packages can be emitted viaWIT_COMPONENT_ENCODING_V2=0
. Note that for wasm-encoded WIT packages both the old and the new format can be decoded irregardless of env vars.