chore(acceptance): add tests for PSM to z:acceptance
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilhelvaci
force-pushed
the
anil/psm-tests
branch
4 times, most recently
from
0c1ae50 to
3b48050
Compare
…0241) closes: Agoric#10138 closes: Agoric#10185 closes: Agoric#10258 ## Description A3P tests for the replace electorate core eval. also adds the replace-electorate-core.js script to upgrade.go since it will now be a part of the chain halting upgrade new tests are as follows: - adds new `n:replace-electorate` which tests for acceptance of new invitations - adds params governance proposal and voting tests to `z:acceptance` ### Security Considerations ### Scaling Considerations ### Documentation Considerations ### Testing Considerations ### Upgrade Considerations
refs: Agoric#10267 ## Description We'll be upgrading Zoe in the next SW upgrade. We need to reset the KREAd subscribers when we do that. ### Security Considerations No broader security implications ### Scaling Considerations Not a scaling concern ### Documentation Considerations I should have remembered this when adding the Zoe upgrade. ### Testing Considerations None ### Upgrade Considerations There's a constraint that we need to enforce when we upgrade Zoe. So far, we've been remembering it, but it would be better to automate.
…ic#10306) closes: Agoric#10274 ## Description Half the EC were able to pass a motion, when a majority should have been required. ### Security Considerations Ordinary vote counting issue. ### Scaling Considerations N/A ### Documentation Considerations None ### Testing Considerations Added tests for committee. ### Upgrade Considerations The change is in the committee code. This needs to be merged before the proposal in Agoric#10164 runs. It [already installs new committee code](https://github.com/Agoric/agoric-sdk/blob/4a33accaeeba27044ab07dd04f64226de1b77759/packages/builders/scripts/inter-protocol/replace-electorate-core.js#L28).
anilhelvaci
force-pushed
the
anil/psm-tests
branch
from
324d3ee to
712f970
Compare
Refs: Agoric/BytePitchPartnerEng#23 fix(acceptance-psm): address change requests
anilhelvaci
force-pushed
the
anil/psm-tests
branch
from
712f970 to
52b67cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/Agoric/BytePitchPartnerEng/issues/23
closes: #XXXX
refs: #XXXX
Description
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations