Use newer TF resources for S3 buckets, rather than the now-deprecated resources #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Plan for ./examples/advanced:will create 20 resources:
|
Terraform Plan for ./examples/simple:will create 17 resources:
|
joshgubler
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of an effort to clear up deprecation warnings (see byu-oit/hw-fargate-api#678).
This can be a semver-patch release (byu-oit/hw-fargate-api#688 (comment)), but the change will create some noise in Terraform plans when first introduced.
BTW, this module already requires AWS provider
>= 3.75.2, so we're not breaking anybody by using the newer resources.