Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing verilog composer #161

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

ganeshgore
Copy link
Contributor

Enhancing Verilog composer functionality, adding the following parameters
definition_list : Specify a list of definitions to compose, default it writes everything
write_blackbox : bool, to skip writing black-box

I added tests also let me know what you think.

write_blackbox options to verilog composer
@jacobdbrown4
Copy link
Collaborator

These look like good enhancements.

Also, it's failing the Travis CI test for python 3.5. In order to get it to pass, you need to specify each dict() as an OrderedDict(). The same goes for PR 159 and 162.

@ganeshgore
Copy link
Contributor Author

Those are old tests I don't know why they are failing now, anyways using OrderDict makes sense I will update that

@ganeshgore
Copy link
Contributor Author

This is fixed if you planned to merge. I will update other PRs with master

@jacobdbrown4
Copy link
Collaborator

Because SpyDrNet is available through PyPi, we periodically do new releases. When we do this, we update the master branch and then publish the updated package on PyPi. To help maintain this procedure, we'd like it if you could change the pull request to merge your branch into a new branch I created called "ganesh_contributions". Then we can begin merging your pull requests and then, when ready, we can merge it into master and release the updated code all at once. Are you able to do that?

@ganeshgore
Copy link
Contributor Author

That sounds great. I can do that.

@ganeshgore ganeshgore changed the base branch from master to ganesh_contributions October 27, 2021 00:57
@benglines benglines merged commit 7435f83 into byuccl:ganesh_contributions Nov 2, 2021
@ganeshgore ganeshgore deleted the verilog_composer branch December 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants