Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Composer 1 - IR changes #162

Open
wants to merge 6 commits into
base: next_release
Choose a base branch
from

Conversation

ganeshgore
Copy link
Contributor

I used many shortcuts while creating HTML composer, so I am trying to split them into multiple pull requests.
This pull request contains additions in ir classes,
I tried to add tests also but I guess that will keep evolving.
We can discuss functionality in more detail and the required tests.

@jacobdbrown4
Copy link
Collaborator

Those added shortcuts in the IR look good! I'm guessing it's failing the Python 3.5 test because of OrderedDict().

@ganeshgore ganeshgore changed the base branch from master to ganesh_contributions October 27, 2021 00:58
@ganeshgore
Copy link
Contributor Author

yes I will fast-forward this once we merge #161, that should fix it

@jacobdbrown4 jacobdbrown4 self-assigned this Oct 27, 2021
@jacobdbrown4
Copy link
Collaborator

I'm going to wait to merge this until we know our plan with extending classes.

@jacobdbrown4
Copy link
Collaborator

Now that extending classes with extensions is an option, would you be able to make the html composer into an extension?

@wirthlin wirthlin deleted the branch byuccl:next_release September 12, 2023 20:36
@wirthlin wirthlin closed this Sep 12, 2023
@jacobdbrown4 jacobdbrown4 reopened this Sep 12, 2023
@jacobdbrown4 jacobdbrown4 changed the base branch from ganesh_contributions to next_release September 12, 2023 21:04
@jacobdbrown4
Copy link
Collaborator

The ganesh_contributions branch was deleted, so the pull request automatically closed. I recreated the branch, reopened the pull request, changed the target branch to next_release, then deleted ganesh_contributions again. For some reason now in the comments above it says the wirthlin deleted next_release but that is not right. He deleted ganesh_contributions. I just thought I would clarify that in a comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants