Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: fix shutdownCancelProfitOrders json tag #1731

Merged
merged 1 commit into from
Sep 5, 2024
Merged

FIX: fix shutdownCancelProfitOrders json tag #1731

merged 1 commit into from
Sep 5, 2024

Conversation

longhutianjie
Copy link
Contributor

fix bad syntax for struct tag value

In fact, the previous json tag cannot be parsed correctly

@bbgokarma-bot
Copy link

Hi @longhutianjie,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 205 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@longhutianjie
Copy link
Contributor Author

Hi @longhutianjie,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 205 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

-- If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best, KarmaBot

polygon: 0xde0f338dbd1d8b22cd3bf3996f62686d6efe3b15

Thanks

@bbgokarma-bot
Copy link

Great! @longhutianjie, I've memorized your address.

@c9s c9s enabled auto-merge September 5, 2024 05:45
@c9s c9s changed the title bug: fix json tag FIX: fix json tag Sep 5, 2024
@c9s c9s changed the title FIX: fix json tag FIX: fix shutdownCancelProfitOrders json tag Sep 5, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.06%. Comparing base (ba913ce) to head (c75a685).
Report is 19 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
+ Coverage   24.00%   24.06%   +0.06%     
==========================================
  Files         614      615       +1     
  Lines       37393    37440      +47     
==========================================
+ Hits         8975     9011      +36     
- Misses      27626    27636      +10     
- Partials      792      793       +1

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50262f2...c75a685. Read the comment docs.

@c9s c9s merged commit 1b40118 into c9s:main Sep 5, 2024
5 checks passed
@bbgokarma-bot
Copy link

Hi @longhutianjie,

Well done! 230 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x899e947bc36ed019a58084aa8df9cbe2e6424d43a79fa97a3a5eaf41b5f57ba8

Thank you for your contribution!

@Sajjon
Copy link

Sajjon commented Sep 9, 2024

Caution

GH user longhutianjie is performing a supply chain attack!
🚫 BLOCK user immediatly and report him to Github 🚫

The first step is getting rid of "first time contributor" status.

The user has manually added the message "Signed-off-by: " to make the commit
look more trust worthy. User has opened similar PRs in all these other
repos in within the same hour:

Furthermore I'm pretty sure this is the same person or group as github.com/vivoxfold3,
who tried performing the attack against these repos, with the exact same style:
Manually adding the message "Signed-off-by: " and making trivial contributions
to many crypto libs within the same hour:

This was referenced Sep 9, 2024
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@longhutianjie @bbgokarma-bot @CLAassistant @Sajjon @c9s