Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): fix some comments #525

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

longhutianjie
Copy link
Contributor

Proposed Changes

fix some comments

Linked Issues

[if applicable, add links to issues resolved by this PR]

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease
  • I have added/updated the documentation

Further comments

[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]

Signed-off-by: longhutianjie <git@before.tech>
@Archento Archento changed the title chore: fix some comments chore(core): fix some comments Sep 6, 2024
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@Sajjon
Copy link

Sajjon commented Sep 9, 2024

@Archento

Caution

GH user longhutianjie is performing a supply chain attack!
🚫 BLOCK user immediatly and report him to Github 🚫

The first step is getting rid of "first time contributor" status.

The user has manually added the message "Signed-off-by: " to make the commit
look more trust worthy. User has opened similar PRs in all these other
repos in within the same hour:

Furthermore I'm pretty sure this is the same person or group as github.com/vivoxfold3,
who tried performing the attack against these repos, with the exact same style:
Manually adding the message "Signed-off-by: " and making trivial contributions
to many crypto libs within the same hour:

Archento added a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants