Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve definition for cross-cluster related endpoints #4294

Merged
merged 4 commits into from
Jul 2, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Jul 2, 2021

What changed?

Why?

  • Improve the contract between source and target cluster for fetching/responding cross cluster tasks

How did you test it?

  • Unit tests

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested review from yux0 and demirkayaender July 2, 2021 17:17
Copy link
Contributor

@demirkayaender demirkayaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@coveralls
Copy link

Pull Request Test Coverage Report for Build d2ffe53b-44f8-4fe0-836e-b8c19ff965ff

  • 50 of 195 (25.64%) changed or added relevant lines in 5 files are covered.
  • 37 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.02%) to 59.747%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/types/mapper/proto/shared.go 40 54 74.07%
common/types/shared.go 0 59 0.0%
common/types/mapper/thrift/shared.go 0 72 0.0%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
host/archivalTest.go 1 97.81%
service/history/queue/timer_queue_processor_base.go 1 78.6%
client/history/client.go 2 40.34%
client/history/metricClient.go 2 47.05%
common/persistence/historyManager.go 2 66.33%
common/task/parallelTaskProcessor.go 2 92.48%
service/history/execution/mutable_state_builder.go 2 69.87%
service/history/handler.go 2 46.0%
common/task/fifoTaskScheduler.go 3 84.54%
Totals Coverage Status
Change from base Build dcdcb324-2af1-440e-99e9-108c15c176f4: -0.02%
Covered Lines: 90453
Relevant Lines: 151394

💛 - Coveralls

@yycptt yycptt merged commit 6964885 into cadence-workflow:master Jul 2, 2021
@yycptt yycptt deleted the improve-cross-cluster-idl branch July 2, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants