Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change canary back to start both worker and starter by default #4587

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

longquanzheng
Copy link
Contributor

What changed?
Change canary back to start both worker and starter by default

Why?
In a previous PR, I changed the default to start worker only. I realized that this is a breaking change as some users told me they are using canary in some release version already. So it's better to not break them.

On another hand, I think starting worker only is useful for manual testing, which can be done already since we have the mode argument. But the default behavior should start all for simplicity.

How did you test it?
Local test

Potential risks

Release notes

Documentation Changes

@longquanzheng longquanzheng requested a review from yycptt October 20, 2021 03:23
@longquanzheng longquanzheng enabled auto-merge (squash) October 20, 2021 05:30
@coveralls
Copy link

coveralls commented Oct 20, 2021

Pull Request Test Coverage Report for Build 19c819e5-315c-4fbf-8231-0308269a98ea

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 97 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.05%) to 56.795%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/matching/matcher.go 2 91.46%
common/task/fifoTaskScheduler.go 4 83.51%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 6 55.04%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/nosql/nosqlTaskStore.go 16 58.37%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 19 77.07%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 34 83.58%
Totals Coverage Status
Change from base Build 92a85973-ef4a-4778-ba60-ab65303ea4cf: -0.05%
Covered Lines: 81478
Relevant Lines: 143459

💛 - Coveralls

@longquanzheng longquanzheng merged commit 942f032 into master Oct 20, 2021
@longquanzheng longquanzheng deleted the qlong-canary-default branch October 20, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants