Change canary back to start both worker and starter by default #4587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Change canary back to start both worker and starter by default
Why?
In a previous PR, I changed the default to start worker only. I realized that this is a breaking change as some users told me they are using canary in some release version already. So it's better to not break them.
On another hand, I think starting worker only is useful for manual testing, which can be done already since we have the
mode
argument. But the default behavior should start all for simplicity.How did you test it?
Local test
Potential risks
Release notes
Documentation Changes