Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change canary back to start both worker and starter by default #4587

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Change canary back to start both worker and starter by default #4587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5602427
Change canary back to start both worker and starter by default
longquanzheng Oct 20, 2021
25feaa3
Merge branch 'master' into qlong-canary-default
longquanzheng Oct 20, 2021
7af64bd
Merge branch 'master' into qlong-canary-default
longquanzheng Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions canary/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ In the `docker/` directory, run:
```
docker-compose -f docker-compose-canary.yml up
```

This will start the canary worker and also the cron canary.

You can modify [the canary worker config](../docker/config/canary/development.yaml) to run against a prod server cluster:
* Use a different mode to start canary worker only for testing
* Update the config to use Thrift/gRPC for communication
Expand All @@ -38,21 +41,21 @@ In the project root, build cadence canary binary:
make cadence-canary
```

Then start canary worker:
Then start canary worker & cron:
```
./cadence-canary start
```
This is essentially the same as
```
./cadence-canary start -mode worker
./cadence-canary start -mode all
```

By default, it will load [the configuration in `config/canary/development.yaml`](../config/canary/development.yaml).
Run `./cadence-canary -h` for details to understand the start options of how to change the loading directory if needed.

This will only start the workers. To start both workers and cron starter:
To start the worker only for manual testing certain cases:
```
./cadence-canary start -mode all
./cadence-canary start -mode worker
```

### 3. Monitoring
Expand Down
2 changes: 1 addition & 1 deletion cmd/canary/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func buildCLI() *cli.App {
Flags: []cli.Flag{
cli.StringFlag{
Name: "mode, m",
Value: canary.ModeWorker,
Value: canary.ModeAll,
Usage: fmt.Sprintf("%v, %v or %v", canary.ModeWorker, canary.ModeCronCanary, canary.ModeAll),
EnvVar: canary.EnvKeyMode,
},
Expand Down