Removed the shadower service for cadence-server #5660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Removed the unused service for shadower.
From the code it looks like the idea was to run the shadower in the background of Cadence server and scanning the workflows in real time. The service pulls and scans the workflows but doesn't follow up on it.
The purpose of doing this is also unclear. Was it implemented to detect the non-determinism in real time for whatever workflows are running on the server?
What was the plan to monitor the outcome of this service?
Why?
The code is redundant and creates noise. Also, it doesn't look like it's serving any purpose. In future if we want to include a real time shadower we can probably utilize the CLI based solution for open source.
How did you test it?
Ran the integration tests.
Potential risks
NA
Release notes
NA
Documentation Changes
NA