Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the shadower service for cadence-server #5660

Merged
merged 2 commits into from
Feb 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions common/dynamicconfig/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -1844,12 +1844,6 @@ const (
// Default value: true
// Allowed filters: N/A
EnableFailoverManager
// EnableWorkflowShadower indicates if workflow shadower is enabled
// KeyName: system.enableWorkflowShadower
// Value type: Bool
// Default value: true
// Allowed filters: N/A
EnableWorkflowShadower
// ConcreteExecutionFixerDomainAllow is which domains are allowed to be fixed by concrete fixer workflow
// KeyName: worker.concreteExecutionFixerDomainAllow
// Value type: Bool
Expand Down Expand Up @@ -4085,11 +4079,6 @@ var BoolKeys = map[BoolKey]DynamicBool{
Description: "EnableFailoverManager indicates if failover manager is enabled",
DefaultValue: true,
},
EnableWorkflowShadower: DynamicBool{
KeyName: "system.enableWorkflowShadower",
Description: "EnableWorkflowShadower indicates if workflow shadower is enabled",
DefaultValue: true,
},
ConcreteExecutionFixerDomainAllow: DynamicBool{
KeyName: "worker.concreteExecutionFixerDomainAllow",
Filters: []Filter{DomainName},
Expand Down
20 changes: 0 additions & 20 deletions service/worker/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ import (
"github.com/uber/cadence/service/worker/scanner/shardscanner"
"github.com/uber/cadence/service/worker/scanner/tasklist"
"github.com/uber/cadence/service/worker/scanner/timers"
"github.com/uber/cadence/service/worker/shadower"
)

type (
Expand Down Expand Up @@ -81,10 +80,8 @@ type (
EnableParentClosePolicyWorker dynamicconfig.BoolPropertyFn
NumParentClosePolicySystemWorkflows dynamicconfig.IntPropertyFn
EnableFailoverManager dynamicconfig.BoolPropertyFn
EnableWorkflowShadower dynamicconfig.BoolPropertyFn
DomainReplicationMaxRetryDuration dynamicconfig.DurationPropertyFn
EnableESAnalyzer dynamicconfig.BoolPropertyFn
EnableWatchDog dynamicconfig.BoolPropertyFn
EnableAsyncWorkflowConsumption dynamicconfig.BoolPropertyFn
HostName string
}
Expand Down Expand Up @@ -177,7 +174,6 @@ func NewConfig(params *resource.Params) *Config {
NumParentClosePolicySystemWorkflows: dc.GetIntProperty(dynamicconfig.NumParentClosePolicySystemWorkflows),
EnableESAnalyzer: dc.GetBoolProperty(dynamicconfig.EnableESAnalyzer),
EnableFailoverManager: dc.GetBoolProperty(dynamicconfig.EnableFailoverManager),
EnableWorkflowShadower: dc.GetBoolProperty(dynamicconfig.EnableWorkflowShadower),
ThrottledLogRPS: dc.GetIntProperty(dynamicconfig.WorkerThrottledLogRPS),
PersistenceGlobalMaxQPS: dc.GetIntProperty(dynamicconfig.WorkerPersistenceGlobalMaxQPS),
PersistenceMaxQPS: dc.GetIntProperty(dynamicconfig.WorkerPersistenceMaxQPS),
Expand Down Expand Up @@ -238,10 +234,6 @@ func (s *Service) Start() {
if s.config.EnableFailoverManager() {
s.startFailoverManager()
}
if s.config.EnableWorkflowShadower() {
s.ensureDomainExists(common.ShadowerLocalDomainName)
s.startWorkflowShadower()
}

if s.config.EnableAsyncWorkflowConsumption() {
cm := s.startAsyncWorkflowConsumerManager()
Expand Down Expand Up @@ -407,18 +399,6 @@ func (s *Service) startFailoverManager() {
}
}

func (s *Service) startWorkflowShadower() {
params := &shadower.BootstrapParams{
ServiceClient: s.params.PublicClient,
DomainCache: s.GetDomainCache(),
TallyScope: s.params.MetricScope,
}
if err := shadower.New(params).Start(); err != nil {
s.Stop()
s.GetLogger().Fatal("error starting workflow shadower", tag.Error(err))
}
}

func (s *Service) startAsyncWorkflowConsumerManager() common.Daemon {
cm := asyncworkflow.NewConsumerManager(
s.GetLogger(),
Expand Down
96 changes: 0 additions & 96 deletions service/worker/shadower/profile.go

This file was deleted.

83 changes: 0 additions & 83 deletions service/worker/shadower/worker.go

This file was deleted.

Loading