Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and identify Xcode 7 simulators #242

Merged
merged 27 commits into from
Sep 16, 2015

Conversation

jmoody
Copy link
Contributor

@jmoody jmoody commented Sep 16, 2015

Motivation

Touch coordinates for iPhone 6* were incorrect because the server was not correctly detecting iPhone 6 devices.

Fixes

Progress On

This is a HUGE commit. Changes to LPVersionRoute are backward compatible with gem < 0.16.2

  • Removed a bunch of legacy code (back to iOS 4/Xcode 3)
  • LPDevice takes responsibility for all things device related.
  • LPTouchUtils device/form factor code replaced with calls to LPDevice
  • Fixes Xcode 7 failing unit tests that were trivially failing
  • Disables failing WebView units for iOS 9 (tests are probably bad).
  • Force XCTest to run on iPhone 5s Simulators
  • Add device_name to key LPVersionRoute
  • Deprecate some truly wonky key/value pairs in LPVersionRoute
  • Add a bunch of helpful key/value pairs to LPVersionRoute
  • Add LPProcessInfoRoute to report [[NSProcessInfo processInfo] environment]

ATTN @krukow @sapieneptus @john7doe @rasmuskl

https://github.com/xamarin/test-cloud-frontend/issues/1711

Avoid multiple calls and allow easier testing
Xcode 5.1.1 not supported so we can just use this check.
Having these in the init made things very difficult to
test and mock.
Stand ins for 3.5in and 4in devices respectively.
The other implementation was wonky.
The code was broken for Xcode 7/iOS 9 and crazy complex.
There are many confusing/legacy key/value pairs.
jmoody added a commit that referenced this pull request Sep 16, 2015
…de-7-simulators

Detect and identify Xcode 7 simulators
@jmoody jmoody merged commit 7bd5a2a into develop Sep 16, 2015
@jmoody jmoody deleted the feature/detect-and-identify-xcode-7-simulators branch September 16, 2015 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant