-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect and identify Xcode 7 simulators #242
Merged
jmoody
merged 27 commits into
develop
from
feature/detect-and-identify-xcode-7-simulators
Sep 16, 2015
Merged
Detect and identify Xcode 7 simulators #242
jmoody
merged 27 commits into
develop
from
feature/detect-and-identify-xcode-7-simulators
Sep 16, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid multiple calls and allow easier testing
Xcode 5.1.1 not supported so we can just use this check.
Having these in the init made things very difficult to test and mock.
Stand ins for 3.5in and 4in devices respectively.
The other implementation was wonky.
The code was broken for Xcode 7/iOS 9 and crazy complex.
There are many confusing/legacy key/value pairs.
jmoody
added a commit
that referenced
this pull request
Sep 16, 2015
…de-7-simulators Detect and identify Xcode 7 simulators
This was referenced Sep 16, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Touch coordinates for iPhone 6* were incorrect because the server was not correctly detecting iPhone 6 devices.
Fixes
Progress On
This is a HUGE commit. Changes to LPVersionRoute are backward compatible with gem < 0.16.2
device_name
to key LPVersionRoute[[NSProcessInfo processInfo] environment]
ATTN @krukow @sapieneptus @john7doe @rasmuskl
https://github.com/xamarin/test-cloud-frontend/issues/1711