Release/0.16.2 #252
Merged
Release/0.16.2 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to suppress warnings re: CocoaLumberjack.a
Use iPhone 6 as Xcode 7 test simulator
Respond to Xcode 7 errors.
Avoid multiple calls and allow easier testing
Xcode 5.1.1 not supported so we can just use this check.
Having these in the init made things very difficult to test and mock.
Stand ins for 3.5in and 4in devices respectively.
The other implementation was wonky.
The code was broken for Xcode 7/iOS 9 and crazy complex.
There are many confusing/legacy key/value pairs.
…de-7-simulators Detect and identify Xcode 7 simulators
Clients < 0.16.2 need this. @see LPVersionRoute
Clients < 0.16.1 need the 'system' key to be just so.
…-be-backward-compatible LPVersionRoute needs to be backward compatible
Was timing out on devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.16.2