Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape binary path in argument to lipo. #101

Merged
merged 1 commit into from
Jan 9, 2015
Merged

Escape binary path in argument to lipo. #101

merged 1 commit into from
Jan 9, 2015

Conversation

gredman
Copy link

@gredman gredman commented Jan 8, 2015

Prevents error if path contains space characters.

Cheers.

Prevents error if path contains space characters.
@jmoody
Copy link
Contributor

jmoody commented Jan 9, 2015

@gredman I caught this shortly after I released. I will be pushing a hotfix later today. Thank you for the PR. I am going to accept this so you get credit, but then rollback in favor of my fix. Thanks again.

@gredman
Copy link
Author

gredman commented Jan 9, 2015

Sweet. I don't really care about getting credit so feel free to just use your fix if it's easier.

Thanks.

jmoody added a commit that referenced this pull request Jan 9, 2015
…-path

Escape binary path in argument to lipo.
@jmoody jmoody merged commit f4704f5 into calabash:develop Jan 9, 2015
@jmoody jmoody mentioned this pull request Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants