-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synthetic fuel production & methane boiler #424
Conversation
b8a3ff5
to
4b805d1
Compare
To note: the synfuel transmission and the need for the "dummy" techs to convert synfuels to fuels will likely disappear when using v0.7. They are there now to be able to distinguish between synthetic fuels and fossil fuels (when I add those) for custom constraints but I think we can circumvent all that with our v0.7 math. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
My only big concern is the transmission of the new carriers. What exactly does this do without a custom constraint? And if that's weird/unexpected, shouldn't we avoid adding transmission at this point?
templates/models/techs/conversion/hydrogen-from-electricity.yaml.jinja
Outdated
Show resolved
Hide resolved
templates/models/techs/conversion/synfuels-from-hydrogen.yaml.jinja
Outdated
Show resolved
Hide resolved
templates/models/techs/conversion/synfuels-from-hydrogen.yaml.jinja
Outdated
Show resolved
Hide resolved
- Remove synfuel transmission - Remove `syn_` prefix on fuels - TODO -> ASSUME - Remove unused fixture
NOTE: this should be reviewed after #419 since it builds on it (I am opening this PR as I will be offline for a few days but still want it to be possible for this to be reviewed once #419 is merged).
Fixes #416.
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.