Web-Specific Fixes for onValueChange and Deprecated React Methods #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify onValueChange in RNCSliderNativeComponent.web.tsx for web platform to ensure it's called only during user interaction. - Replace deprecated StyleSheet.compose with array syntax in Slider.tsx and RNCSliderNativeComponent.web.tsx.
- Adjust onResponderMove and closing tag syntax for better readability and consistency - Ensure adherence to project's linting rules for cleaner code structure
- Adjust the style array in Slider.tsx to conditionally include props.style - Resolve snapshot test failures by preventing inclusion of undefined in style array - Eliminate the need for updating snapshots as component rendering remains consistent
|
Sorry for the recent series of updates. Initially, I patched this package for personal use and subsequently decided to submit a PR. While the original sources were Ok, there were some minor issues with linting and test snapshots. I have now addressed these issues. |
|
@landabaso No need to apologize :) These are just two commits, especially both with awesome commit messages and good input 👍 |
|
Thanks. No problem on the timing. I'm currently using a patched version and testing it across iOS, Android, and Web. I'll keep you updated if anything comes up, but it seems solid right now. |
BartoszKlonowski
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web-Specific Fixes for onValueChange and Deprecated React Methods
Changes:
onValueChangeinRNCSliderNativeComponent.web.tsxto trigger only during user interactions, addressing platform-specific inconsistencies (issue Clarification ononValueChangeBehavior Across Platforms #562).Slider.tsxandRNCSliderNativeComponent.web.tsx, replacing deprecatedStyleSheet.composewith array syntax.These updates fixes an inconsistency in the web platform and improves compatibility with newer React versions.
Related Issue: #562