Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web-Specific Fixes for onValueChange and Deprecated React Methods #563

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Web-Specific Fixes for onValueChange and Deprecated React Methods #563

merged 3 commits into from
Dec 22, 2023

Commits on Dec 17, 2023

  1. Fix web-specific onValueChange behavior and deprecate React methods 

    - Modify onValueChange in RNCSliderNativeComponent.web.tsx for web platform to ensure it's called only during user interaction.
- Replace deprecated StyleSheet.compose with array syntax in Slider.tsx and RNCSliderNativeComponent.web.tsx.
    @landabaso
    landabaso committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    d86ddb1 View commit details
    Browse the repository at this point in the history

  2. Fix linting issues and improve code formatting in slider component 

    - Adjust onResponderMove and closing tag syntax for better readability and consistency
- Ensure adherence to project's linting rules for cleaner code structure
    @landabaso
    landabaso committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    0ddb47c View commit details
    Browse the repository at this point in the history

  3. Fix snapshot test issues by refining style definition in Slider 

    - Adjust the style array in Slider.tsx to conditionally include props.style
- Resolve snapshot test failures by preventing inclusion of undefined in style array
- Eliminate the need for updating snapshots as component rendering remains consistent
    @landabaso
    landabaso committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    989700d View commit details
    Browse the repository at this point in the history