Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate r2.2 #254

Merged
merged 6 commits into from
Jan 31, 2025
Merged

Release Candidate r2.2 #254

merged 6 commits into from
Jan 31, 2025

Conversation

jpengar
Copy link
Collaborator

@jpengar jpengar commented Jan 24, 2025

What type of PR is this?

  • subproject management

What this PR does / why we need it:

This is the release PR for the pre-release r2.2 (first release candidate for Spring25) containing version v0.3.0-rc.1 of ICM

Which issue(s) this PR fixes:

It is related to #193

Special notes for reviewers:

This PR includes all changes in the ICM scope of the Spring25 meta-release as defined in #193. No further changes other than minor adjustments and error fixes are expected before the public release.

Changelog input

 r2.2 containing version v0.3.0-rc.1 of ICM

Additional documentation

https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/14551399/Meta-release+Process#Commonalities-and-ICM
https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/14560849/Meta-release+Spring25

@jpengar jpengar requested a review from a team January 24, 2025 13:05
Copy link

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all,
the release PR looks good:

  • one comment for clarity in the readme,
  • one on a fix of the mandatory template. which I leave to you if you want to still include it. No update of the changleog is needed for that IMHO as covered by some previous issues and by the statement in the beginning of the Changelog that the mandatory template has been updated.

With that /LGTM from Release Management side.
I approve to speed up the process (though not sure if it works that way, but ...)

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
AxelNennker
AxelNennker previously approved these changes Jan 28, 2025
@hdamker hdamker self-requested a review January 30, 2025 08:44
sebdewet
sebdewet previously approved these changes Jan 30, 2025
Copy link
Collaborator

@sebdewet sebdewet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sebdewet sebdewet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... especially also the last commit.

@jpengar
Copy link
Collaborator Author

jpengar commented Jan 30, 2025

I will merge this PR tomorrow if there are no further comments. The ICM r2.2 release will be ready before the weekend.

Copy link

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Release Mgmt

@jpengar jpengar merged commit 46beef3 into main Jan 31, 2025
1 check passed
@jpengar jpengar deleted the jpengar/icm-release-r2.2 branch January 31, 2025 08:01
Copy link
Contributor

@Elisabeth-Ericsson Elisabeth-Ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much clearer now, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants