feat(zeebe): support Job Corrections in complete command fixes #347 #348
Conversation
| const res1 = await job.completeWithJobResult({ | ||
| variables: {}, | ||
| result: { | ||
| denied: true, | ||
| }, |
There was a problem hiding this comment.
💭 Given the test case (the process has a service task for which this job worker code will run) this code may eventually break.
Job result is at this time only meant to be used for User Task Listeners.
For now, we allow regular job completions with a job result ignoring the result. However, in the future we may add validations against it.
🔧 As a more durable test case, please consider a Camunda User Task with a completing task listener. You can then try to complete the user task, which creates a job that you can activate and complete with a job result.
| // * `assignee` - reset by providing an empty String | ||
| // * `dueDate` - reset by providing an empty String | ||
| // * `followUpDate` - reset by providing an empty String | ||
| // * `candidateGroups` - reset by providing an empty list | ||
| // * `candidateUsers` - reset by providing an empty list |
There was a problem hiding this comment.
🔧 The language in this documentation was changed for clarity. Would be good to take along in this sdk as well: reset has become clear for the Job Result corrections
| // * `assignee` - reset by providing an empty String | |
| // * `dueDate` - reset by providing an empty String | |
| // * `followUpDate` - reset by providing an empty String | |
| // * `candidateGroups` - reset by providing an empty list | |
| // * `candidateUsers` - reset by providing an empty list | |
| // * `assignee` - clear by providing an empty String | |
| // * `dueDate` - clear by providing an empty String | |
| // * `followUpDate` - clear by providing an empty String | |
| // * `candidateGroups` - clear by providing an empty list | |
| // * `candidateUsers` - clear by providing an empty list |
Description of the change
[Describe your changes here]
Type of change
Checklist
alphabranchFurther comments
[If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...]