Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Acquisition team] Add buttons to navbar #384

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

akeller
Copy link
Member

@akeller akeller commented Aug 8, 2023

Follow up to camunda/camunda-docs-theme#41 and adding the changes to this part of the docs site.

There were many other changes I noticed locally, including changes to shortcode files and sitemaps, but these are not in the scope of this PR.

@akeller akeller requested review from pepopowitz and tasso94 August 8, 2023 16:04
@akeller akeller self-assigned this Aug 8, 2023
@akeller
Copy link
Member Author

akeller commented Aug 8, 2023

@tasso94, I've added you as a reviewer but feel free to delegate.

Copy link
Contributor

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of my feedback applies to all 3 "sites", not just the one I commented on.

enterprise/themes/camunda/layouts/partials/header.html Outdated Show resolved Hide resolved
enterprise/themes/camunda/layouts/partials/header.html Outdated Show resolved Hide resolved
get-started/themes/camunda/assets/css/docs.css Outdated Show resolved Hide resolved
@akeller
Copy link
Member Author

akeller commented Aug 8, 2023

Hmm... this has a lot more deletions than I expected to see.

@pepopowitz
Copy link
Contributor

pepopowitz commented Aug 8, 2023

Hmm... this has a lot more deletions than I expected to see.

I think it's because 2 of the 3 sites didn't have minified assets.

So, you fixed them. Nice work!

Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@akeller akeller merged commit e80b89c into master Aug 15, 2023
@akeller akeller deleted the acquisition-team-navbar-change branch August 15, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants