-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add buttons above navbar #41
Conversation
Hi @jpgwebdev, Thank you for your contribution! I think it makes sense to have a link for Camunda 8 docs, in case someone went to My impressions right now:
I will add some more ideas later. -Daniel |
More context on the internal Camunda Slack - https://camunda.slack.com/archives/C6M6X3EKZ/p1684769980750839 FYI @pepopowitz |
@danielkelemen did you have more feedback on this? This is part of an Acquisition Team experiment. Sorry for not making that clearer earlier in the comments or description. |
@danielkelemen any further feedback here? |
Hi @akeller, |
@akeller @danielkelemen On smaller screens the content won't fit correctly. How should I proceed? |
@jpguisa My quick answer is just to hide the nav you added on smaller screens. This is the issue with having multiple navs when space is already limited. Since this is technically an experiment (or initially designed to be an experiment), hiding this nav for small screens is the best path forward. I will sync with the team internally on this as well. |
@akeller It is already hidden for screens smaller than 800px width |
@pepopowitz should the package-lock.json file be included in the PR? |
No, it shouldn't, that's strange that it updated. @jpguisa can you please revert the changes to that file? |
@pepopowitz Done! |
Added docs, create account and signup links above navbar on the right corner