Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add buttons above navbar #41

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

jpguisa
Copy link
Contributor

@jpguisa jpguisa commented Jun 17, 2023

Added docs, create account and signup links above navbar on the right corner

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2023

CLA assistant check
All committers have signed the CLA.

@danielkelemen
Copy link
Member

Hi @jpgwebdev,

Thank you for your contribution!

I think it makes sense to have a link for Camunda 8 docs, in case someone went to docs.camunda.org instead of docs.camunda.io accidentally.
But I think it should be somehow better integrated into the page. Right now, I'm not sure how exactly. If you have any better ideas, feel free to add them.

My impressions right now:

  • I would probably stick to the one level navbar instead of the two you added.
  • Also I think it would be enough to add a link to C8 docs. No need for the other two buttons.

I will add some more ideas later.

-Daniel

@akeller
Copy link
Member

akeller commented Jun 27, 2023

More context on the internal Camunda Slack - https://camunda.slack.com/archives/C6M6X3EKZ/p1684769980750839

FYI @pepopowitz

styles/_navbar.less Show resolved Hide resolved
@akeller
Copy link
Member

akeller commented Jul 12, 2023

@danielkelemen did you have more feedback on this? This is part of an Acquisition Team experiment. Sorry for not making that clearer earlier in the comments or description.

@akeller
Copy link
Member

akeller commented Jul 28, 2023

@danielkelemen any further feedback here?

@danielkelemen
Copy link
Member

Hi @akeller,
The header is not visible on smaller screens.
No further feedback from me.

@danielkelemen danielkelemen removed their request for review July 31, 2023 08:42
@akeller
Copy link
Member

akeller commented Jul 31, 2023

Hi @akeller, The header is not visible on smaller screens. No further feedback from me.

@jpguisa can you please make adjustments here?

@jpguisa
Copy link
Contributor Author

jpguisa commented Jul 31, 2023

@akeller @danielkelemen On smaller screens the content won't fit correctly. How should I proceed?

image

@akeller
Copy link
Member

akeller commented Jul 31, 2023

@jpguisa My quick answer is just to hide the nav you added on smaller screens. This is the issue with having multiple navs when space is already limited. Since this is technically an experiment (or initially designed to be an experiment), hiding this nav for small screens is the best path forward. I will sync with the team internally on this as well.

@jpguisa
Copy link
Contributor Author

jpguisa commented Jul 31, 2023

@akeller It is already hidden for screens smaller than 800px width

@akeller
Copy link
Member

akeller commented Jul 31, 2023

@pepopowitz should the package-lock.json file be included in the PR?

@pepopowitz
Copy link
Contributor

@pepopowitz should the package-lock.json file be included in the PR?

No, it shouldn't, that's strange that it updated. @jpguisa can you please revert the changes to that file?

@jpguisa
Copy link
Contributor Author

jpguisa commented Jul 31, 2023

@pepopowitz Done!

@akeller akeller merged commit d6b65b7 into camunda:master Aug 7, 2023
@akeller
Copy link
Member

akeller commented Aug 7, 2023

Even though this is merged, the changes need to be added to the static and manual repos. @jpguisa you can do this, or I'll add this to my list of this to do this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants