Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorcpp #116

Merged
merged 357 commits into from
Jan 18, 2024
Merged

Refactorcpp #116

merged 357 commits into from
Jan 18, 2024

Conversation

stevencarlislewalker
Copy link
Member

@stevencarlislewalker stevencarlislewalker commented Sep 14, 2023

Getting ready to bump the major version by merging this refactorcpp branch. This branch is pretty much backwards incompatible. There are exceptions, but not many. The word 'refactor' in the branch name is not correct, because a refactor implies that the user-facing experience is unchanged -- not true in this case. We set out to do a refactor but then decided otherwise.

@stevencarlislewalker stevencarlislewalker self-assigned this Sep 14, 2023
@stevencarlislewalker stevencarlislewalker added documentation Improvements or additions to documentation engine Component: C++ / TMB Engine engine adaptor Component: R-side data structure for defining engine-level models engine adaptor constructors Component: Tools for converting model definition files into an engine adaptor model definition files Component: Spec for compartmental model definition schema model space operations Component: Tools for editing and combining compartmental models labels Sep 19, 2023
@bbolker
Copy link
Collaborator

bbolker commented Nov 18, 2023

One of the take-home messages from the BIRS workshop session was that having our current development version on a non-default branch is confusing.

What will it take to merge refactorcpp with main/master, e.g.

  • update all vignettes to work with this branch (and revert 432985c). That might be a pretty good test (what is our current test coverage stat?
  • document levels of back compatibility (i.e. code should still work, but saved model objects won't) and tag the current HEAD of the main branch for people who want to get back to/stay at that point
  • maybe release oor to CRAN in preparation for releasing macpan2 ?
  • set up workflow for building binary packages and pushing them to drat

?

@bbolker
Copy link
Collaborator

bbolker commented Jan 17, 2024

FWIW the action is currently failing in the setup stages, apparently while trying to unpack the withr binary. withr was updated on CRAN yesterday, so it wouldn't surprise me if this were a transient problem ...

@stevencarlislewalker
Copy link
Member Author

FWIW the action is currently failing in the setup stages, apparently while trying to unpack the withr binary. withr was updated on CRAN yesterday, so it wouldn't surprise me if this were a transient problem ...

I had the same thought. I'll wait a bit.

@stevencarlislewalker stevencarlislewalker merged commit 097a4e0 into main Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation engine adaptor constructors Component: Tools for converting model definition files into an engine adaptor engine adaptor Component: R-side data structure for defining engine-level models engine Component: C++ / TMB Engine model definition files Component: Spec for compartmental model definition schema model space operations Component: Tools for editing and combining compartmental models
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants