Skip to content

Commit

Permalink
tests: use dex-auth svc DNS name as public-url (#1012)
Browse files Browse the repository at this point in the history
For CKF 1.8, dex-auth and oidc-gatekeeper's public-url config option can be set to
http://dex-auth.kubeflow.svc:5556, this is because the whole authentication process is
done internally in the cluster with dex-auth as an IdP and oidc-gatekeeper as an OIDC client.
  • Loading branch information
DnPlas authored Aug 7, 2024
1 parent 34801f6 commit 3b3138d
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions tests/integration/test_bundle_deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ async def test_bundle_deployment_works(self, ops_test: OpsTest, lightkube_client
raise_on_error=False,
timeout=1500,
)

dex_svc_dns_name = "http://dex-auth.kubeflow.svc:5556"

await ops_test.model.applications["dex-auth"].set_config({"public-url": url})
await ops_test.model.applications["oidc-gatekeeper"].set_config({"public-url": url})
await ops_test.model.applications["dex-auth"].set_config({"public-url": dex_svc_dns_name})
await ops_test.model.applications["oidc-gatekeeper"].set_config({"public-url": dex_svc_dns_name})

# Wait for the whole bundle to become active and idle
await ops_test.model.wait_for_idle(
Expand Down

0 comments on commit 3b3138d

Please sign in to comment.