tests: use dex-auth svc DNS name as public-url #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For CKF 1.8, dex-auth and oidc-gatekeeper's public-url config option can be set to http://dex-auth.kubeflow.svc:5556, this is because the whole authentication process is done internally in the cluster with dex-auth as an IdP and oidc-gatekeeper as an OIDC client.
orfeas-k
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Thanks for fixing it, it runs successfully https://github.com/canonical/bundle-kubeflow/actions/runs/10282312112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CKF 1.8, dex-auth and oidc-gatekeeper's public-url config option can be set to http://dex-auth.kubeflow.svc:5556, this is because the whole authentication process is done internally in the cluster with dex-auth as an IdP and oidc-gatekeeper as an OIDC client.
For more information about how this works, please see #608 (comment)