fix(charm_builder): force-install pip #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version wasn't installing pip if it was already in the venv Fixes #1456 CRAFT-2538
mattculler
approved these changes
Sep 11, 2024
mr-cal
approved these changes
Sep 12, 2024
|
@mattculler we only need to do so if the version of pip that's added in the venv is older than the minimum version that supports our needed feature set (as is the case on focal, for example). But we're checking the pip version before running that command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version wasn't installing pip if it was already in the venv.
This is the hotfix for 3.x, while #1891 is the hotfix for 2.x.
Fixes #1456
CRAFT-2538