Strict dependencies prevents charm from building

[carlcsaposs-canonical]

Bug Description

ModuleNotFoundError: No module named 'markupsafe' when building charm with charm-strict-dependencies: true

To Reproduce

git clone https://github.com/canonical/mysql-router-operator
git checkout with-hashes
tox run -e pack-wrapper
mv requirements-last-build.txt requirements.txt
charmcraft pack

Environment

Ubuntu 22.04

charmcraft.yaml

# Copyright 2022 Canonical Ltd.
# See LICENSE file for licensing details.

type: charm
bases:
  # Whenever "bases" is changed:
  # - Update tests/integration/conftest.py::pytest_configure()
  # - Update .github/workflow/ci.yaml integration-test matrix
  - build-on:
      - name: "ubuntu"
        channel: "20.04"
    run-on:
      - name: "ubuntu"
        channel: "20.04"
  - build-on:
      - name: "ubuntu"
        channel: "22.04"
    run-on:
      - name: "ubuntu"
        channel: "22.04"
parts:
  charm:
    override-pull: |
      craftctl default
      if [[ ! -f requirements.txt ]]
      then
          echo 'ERROR: Use "tox run -e build" instead of calling "charmcraft pack" directly' >&2
          exit 1
      fi
    charm-strict-dependencies: true
    charm-entrypoint: src/machine_charm.py

Relevant log output

charmcraft-20240103-154031.230848.log

[carlcsaposs-canonical]

Not sure if this a bug or not (haven't had time to thoroughly investigate), but thought you might want to know we're running into this

I was imagining that we'd be able to enable strict dependencies for every charm

[lengau]

Thanks for the report! This is a charmcraft bug in that it's not always grabbing the correct version of pip 🙃

You can replicate the failure by firing up a venv with pip 20.0.2 and running pip install --no-binary=jinja2,markupsafe jinja2

The Jammy build should still work though.

When getting pip, we need to specify that we want pip>=23.2.1 (here:

charmcraft/charmcraft/charm_builder.py

Line 240 in 2567c66

_process_run([pip_cmd, "install", f"pip@{KNOWN_GOOD_PIP_URL}"])

)

[ca-scribner]

I'm hitting this as well - is there a workaround that a charm can use to sort this out temporarily?

[syncronize-issues-to-jira]

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-2538.

This message was autogenerated

[carlcsaposs-canonical]

It looks like charmcraft 2.7.1 doesn't upgrade pip, so I don't think this issue has been fixed

e.g. https://github.com/canonical/mysql-router-operator/actions/runs/10073593563/job/27847987389?pr=164#step:12:64