Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: trust kubeflow-volumes #382

Merged
merged 5 commits into from
Feb 29, 2024
Merged

test: trust kubeflow-volumes #382

merged 5 commits into from
Feb 29, 2024

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Feb 23, 2024

This charm now requires to be trusted at deployment time.

canonical/kubeflow-volumes-operator#125 refactored kubeflow-volumes, which now requires to be trusted.

This charm now requires to be trusted at deployment time.
ca-scribner
ca-scribner previously approved these changes Feb 23, 2024
@ca-scribner
Copy link
Contributor

This change lgtm, but I don't understand why the CI is failing. It feels like it is unrelated

@ca-scribner
Copy link
Contributor

I can't reproduce this issue locally, but I do see canonical/charmcraft#1456 I think reporting the same thing. Tried pushing an update to the charmcraft.yaml file to force a newer pip version - let's see how that goes

@ca-scribner
Copy link
Contributor

I'm not sure how to fix this, but pinning to charmcraft 2.2 and trying to pin pip didn't work so I've reverted those attempts

@ca-scribner
Copy link
Contributor

Also it seems like the errors might be intermittent, and that they only happen during the integration tests. The publish step, which also builds these charms, always succeeded for me(???)

@DnPlas
Copy link
Contributor Author

DnPlas commented Feb 26, 2024

Hey @ca-scribner not sure why you were looking at pip and other dependencies, but this PR is trying to fix the permission issues that the kubeflow-volumes was throwing in a previous CI run

unit-kubeflow-volumes-0: 10:50:31 ERROR unit.kubeflow-volumes/0.juju-log ingress:2: Failed to compute status for kubernetes:auth during assessment of prerequisites for container:kubeflow-volumes.  Got err: customresourcedefinitions.apiextensions.k8s.io is forbidden: User "system:serviceaccount:test-istio:kubeflow-volumes" cannot list resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope

Because the kubeflow-volumes charm was re-written to sidecar, we need to trust it in any tests that depend on it.

@DnPlas DnPlas merged commit 0499f23 into main Feb 29, 2024
17 checks passed
@DnPlas DnPlas deleted the dnplas-trust-volumes branch February 29, 2024 12:41
@ca-scribner
Copy link
Contributor

@DnPlas check out the failures in the original CI runs like here - something intermittent is happening. Agreed that this PR did not cause them, but it is affected by them

@ca-scribner
Copy link
Contributor

The CI for this PR during merge also failed. I don't think we should have merged this PR yet, since it had a good chance of failing the CI and not publishing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants