-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: trust kubeflow-volumes #382
Conversation
This charm now requires to be trusted at deployment time.
This change lgtm, but I don't understand why the CI is failing. It feels like it is unrelated |
I can't reproduce this issue locally, but I do see canonical/charmcraft#1456 I think reporting the same thing. Tried pushing an update to the charmcraft.yaml file to force a newer pip version - let's see how that goes |
I'm not sure how to fix this, but pinning to charmcraft 2.2 and trying to pin pip didn't work so I've reverted those attempts |
Also it seems like the errors might be intermittent, and that they only happen during the integration tests. The publish step, which also builds these charms, always succeeded for me(???) |
Hey @ca-scribner not sure why you were looking at
Because the kubeflow-volumes charm was re-written to sidecar, we need to trust it in any tests that depend on it. |
The CI for this PR during merge also failed. I don't think we should have merged this PR yet, since it had a good chance of failing the CI and not publishing |
This charm now requires to be trusted at deployment time.
canonical/kubeflow-volumes-operator#125 refactored kubeflow-volumes, which now requires to be trusted.