Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure driver to support GPU tests #138

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Nov 22, 2024

Implement changes as speced in the spec.
TDLR:

  • Split tests to cpu and gpu
  • Add --include-gpu-tests flag to include the tests under the gpu directory.
  • Pass this flag to the tests job (together with the filter one) to include the appropriate tests.

Closes #132

Testing

In order to test the PR

  • Spin up a cluster with a GPU. For a two node microk8s node with one gpu, refer to this comment Exploration task for running UATs using GPU #130 (comment)
  • Run with the --include-gpu-tests flag e.g.
    tox -e uats-remote -- --include-gpu-tests --filter "placeholder"
    
    You should see only placeholder in the list (due the flag including it and filter making sure no other tests are run) and the job logs should include:
test_notebooks.py::test_notebook[placeholder] 
-------------------------------- live log call ---------------------------------
INFO     test_notebooks:test_notebooks.py:48 Note that only CPU tests will be run. In order to run tests that use an NVIDIA GPU,use the `--include-gpu-tests` flag e.g. `tox -e kubeflow-local -- --include-gpu-tests`.To learn more, use `--help` or refer to the repository's README file.
INFO     test_notebooks:test_notebooks.py:55 Running placeholder.ipynb...
PASSED                                                                   [100%]

======================= 1 passed, 9 deselected in 7.56s ========================
PASSED

You could also run something without --include-gpu-tests in order to confirm that this PR does not affect running cpu UATs.

Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @orfeas-k , left a couple comments, and:

  1. Is the README.md going to be updated in a different PR?
  2. Can you provide testing instructions for the PR? Not sure how to tackle this

driver/test_kubeflow_workloads.py Show resolved Hide resolved
tests/test_notebooks.py Show resolved Hide resolved
tests/test_notebooks.py Outdated Show resolved Hide resolved
@orfeas-k orfeas-k merged commit fe35a1b into main Nov 28, 2024
1 check passed
@orfeas-k orfeas-k deleted the kf-6524-configure-driver-gpu branch November 28, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure driver in order to be able to run GPU-enabled UATs
2 participants